-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrderPaymentInterface is missing setAdditionalInformation() #26745
Comments
Hi @antoninobonumore. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @antoninobonumore do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @antoninobonumore. Thank you for working on this issue.
|
…op expedited Accepted Community Pull Requests: - #27298: Implement ActionInterface for `cms/page/view` (by @lbajsarowicz) - #27116: Add Italy States (by @WaPoNe) - #26748: #26745 add method setAdditionalInformation to OrderPaymentInte… (by @antoninobonumore) - #27336: fixed My account Address Book Additional Address Entries table issue #27335 (by @abrarpathan19) - #27263: #26708 Fix: ORDER BY has two similar conditions in the SQL query (by @vasilii-b) - #27304: FIX #14080 Added improvements to Category repository (save method) (by @sergiy-v) - #27214: Mark AbstractAccount as DEPRECATED for Magento_Customer controllers (by @lbajsarowicz) - #27292: Magento_Bundle / Remove `cache:flush` and extract Tests to separate files (by @lbajsarowicz) Fixed GitHub Issues: - #26708: ORDER BY has two similar conditions (reported by @Usik2203) has been fixed in #27263 by @vasilii-b in 2.4-develop branch Related commits: 1. 1e1ebd3 2. df35dda 3. b816334 4. a61d92a
Summary
OrderPaymentInterface misses a setter for additional_information: this is an inconsistency between its schema declaration and the real properties accepted.
Examples
If you declare an API interface that accepts as a parameter an object of the type OrderPaymentInterface, additional_information property should be accepted.
The result is this error:
Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface".
Forcing developer to unset additional_information before sending this object
A validation of this schema can be triggered in this way:
Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface".
will be triggered due the fact that additional_information property is defined (getAdditionalInformation() exists and swagger use that to define its sample call).Proposed solution
Implement a setter setAdditionalInformation() in OrderPaymentInterface: model using this interface have already got this method.
The text was updated successfully, but these errors were encountered: