Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderPaymentInterface is missing setAdditionalInformation() #26745

Closed
antoninobonumore opened this issue Feb 7, 2020 · 2 comments · Fixed by #26748
Closed

OrderPaymentInterface is missing setAdditionalInformation() #26745

antoninobonumore opened this issue Feb 7, 2020 · 2 comments · Fixed by #26748
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@antoninobonumore
Copy link
Member

antoninobonumore commented Feb 7, 2020

Summary

OrderPaymentInterface misses a setter for additional_information: this is an inconsistency between its schema declaration and the real properties accepted.

Examples

If you declare an API interface that accepts as a parameter an object of the type OrderPaymentInterface, additional_information property should be accepted.
The result is this error:
Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface".
Forcing developer to unset additional_information before sending this object

A validation of this schema can be triggered in this way:

  • create an integration token in admin with permission over Sales > Order > Operation > Create
  • use swagger interface to test this endpoint salesOrderRepositoryV1SavePutBody
  • the exception
    Property "AdditionalInformation" does not have accessor method "setAdditionalInformation" in class "Magento\Sales\Api\Data\OrderPaymentInterface". will be triggered due the fact that additional_information property is defined (getAdditionalInformation() exists and swagger use that to define its sample call).

Proposed solution

Implement a setter setAdditionalInformation() in OrderPaymentInterface: model using this interface have already got this method.

@antoninobonumore antoninobonumore added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 7, 2020
@antoninobonumore antoninobonumore self-assigned this Feb 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @antoninobonumore. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@antoninobonumore do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @antoninobonumore. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 7, 2020
antoninobonumore added a commit to antoninobonumore/magento2 that referenced this issue Feb 7, 2020
@ghost ghost unassigned antoninobonumore Feb 7, 2020
@ghost ghost assigned antoninobonumore Feb 7, 2020
magento-engcom-team added a commit that referenced this issue Mar 21, 2020
…ntInte… #26748

 - Merge Pull Request #26748 from antoninobonumore/magento2:2.4-develop
 - Merged commits:
   1. c5ca58c
   2. 4084004
   3. e785e7b
   4. f7f72ab
magento-engcom-team added a commit that referenced this issue Mar 21, 2020
…ntInte… #26748

 - Merge Pull Request #26748 from antoninobonumore/magento2:2.4-develop
 - Merged commits:
   1. c5ca58c
   2. 4084004
   3. e785e7b
   4. f7f72ab
   5. 681ea9f
magento-engcom-team added a commit that referenced this issue Mar 21, 2020
…op expedited

Accepted Community Pull Requests:
 - #27298: Implement ActionInterface for `cms/page/view` (by @lbajsarowicz)
 - #27116: Add Italy States (by @WaPoNe)
 - #26748: #26745 add method setAdditionalInformation to OrderPaymentInte… (by @antoninobonumore)
 - #27336: fixed My account Address Book Additional Address Entries table issue #27335 (by @abrarpathan19)
 - #27263: #26708 Fix: ORDER BY has two similar conditions in the SQL query (by @vasilii-b)
 - #27304: FIX #14080 Added improvements to Category repository (save method) (by @sergiy-v)
 - #27214: Mark AbstractAccount as DEPRECATED for Magento_Customer controllers (by @lbajsarowicz)
 - #27292: Magento_Bundle / Remove `cache:flush` and extract Tests to separate files (by @lbajsarowicz)


Fixed GitHub Issues:
 - #26708: ORDER BY has two similar conditions (reported by @Usik2203) has been fixed in #27263 by @vasilii-b in 2.4-develop branch
   Related commits:
     1. 1e1ebd3
     2. df35dda
     3. b816334
     4. a61d92a
This was referenced May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants