Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed My account Address Book Additional Address Entries table issue #27335 #27336

Merged
merged 1 commit into from
Mar 21, 2020
Merged

fixed My account Address Book Additional Address Entries table issue #27335 #27336

merged 1 commit into from
Mar 21, 2020

Conversation

abrarpathan19
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. My account Address Book Additional Address Entries table issue #27335 My account Address Book Additional Address Entries table issue

Manual testing scenarios (*)

  1. Login to Luma theme front end -> My account -> Address Book -> Address Entries table
  2. See the table head aliment issue in (Tablet, Desktop)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2020

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@edenduong edenduong self-assigned this Mar 18, 2020
@edenduong
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@edenduong edenduong added Component: Customer Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 18, 2020
@edenduong
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@edenduong
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @edenduong. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7153 has been created to process this Pull Request

@abrarpathan19
Copy link
Contributor Author

@edenduong Thanks for approving PR

@engcom-Bravo engcom-Bravo self-assigned this Mar 20, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

See the screenshot made BEFORE switching to PR

pr 27336_before

and AFTER switching to the PR

pr 27336_after

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@engcom-Echo engcom-Echo self-assigned this Mar 20, 2020
@ghost ghost added the Progress: accept label Mar 20, 2020
magento-engcom-team pushed a commit that referenced this pull request Mar 21, 2020
@slavvka
ENGCOM-7153: fixed My account Address Book Additional Address Entries…
9c4e021 
… table issue #27335 #27336
@magento-engcom-team magento-engcom-team merged commit 1c9fcd7 into magento:2.4-develop Mar 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 21, 2020

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request Apr 30, 2020
Closed
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenduong edenduong edenduong approved these changes

Assignees

@edenduong edenduong

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abrarpathan19 @edenduong @magento-engcom-team @engcom-Bravo @engcom-Echo