Mark AbstractAccount as DEPRECATED for Magento_Customer controllers

[lbajsarowicz]

Description (*)

According to recent changes in favour of Composition over inheritance in Magento 2 Controller Structure - I've introduced changes to Account controllers. That is the first step - make AbstractAccount deprecated.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Reattached the Authorization plugin to AccountInterface from AbstractAccount

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

@magento give me test instance

[magento-engcom-team]

Hi @lbajsarowicz. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @lbajsarowicz, here is your new Magento instance.
Admin access: https://pr-27214.instances.magento-community.engineering/admin_1fd8
Login: 4666e69a Password: dbaf08ab16c8
Instance will be terminated in up to 3 hours.

[lbajsarowicz]

PS: I wanted to move Plugin to the right location Magento\Customer\Plugin\AccountControllerPermissionPlugin however this change is strongly backwards-incompatible. If you have any idea how to handle that other way - I'd love to see your PR to achieve this :-)

[lbajsarowicz]

There was a logical issue because even if you were not permitted to Action, the execute was called.
Thanks @lenaorobei for finding :-)

[lbajsarowicz]

As we don't implement AbstractAction

magento2/lib/internal/Magento/Framework/App/FrontController.php

Lines 159 to 166 in 510310b

	//Validation did not produce a result to replace the action's.
	if (!$result) {
	if ($actionInstance instanceof AbstractAction) {
	$result = $actionInstance->dispatch($request);
	} else {
	$result = $actionInstance->execute();
	}
	}

I'm not going to put any flags around execute.

[lenaorobei]

Can write some integration tests to verify that some actions are allowed for authorized customers only?

[lenaorobei]

⚠️ QA notes:
Need to create controller and implement AccountInterface and make sure that only logged in customer has access to this route. Guests should have a redirect.

• check B2B company scenarios.

[engcom-Alfa]

@dmytro-ch Could you review the latest changes? Thanks!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-7107 has been created to process this Pull Request

[engcom-Echo]

✔️ QA Passed

[engcom-Echo]

@magento run all tests

[engcom-Echo]

Failed functional tests not related to the changes in this PR

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.