Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento#26745 add method setAdditionalInformation to OrderPaymentInte… #26747

Closed

Conversation

antoninobonumore
Copy link
Member

Description (*)

No setter for additional_information in OrderPaymentInterface is defined: this is an inconsistency between its schema declaration and the real properties accepted.

Fixed Issues (if relevant)

#26745: OrderPaymentInterface is missing setAdditionalInformation()

Manual testing scenarios (*)

  • create an API interface accepting OrderPaymentInterface
  • try to set an object with a property additional_information with a value

Questions or comments

IMO this looks like an elephant in the room since this definition is missing from a long time in the definition of this interface

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @antoninobonumore. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @antoninobonumore, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants