adding istion annotation (#3534) #3557

vayyappaneni · 2020-07-09T17:03:43Z

Fixes #3532
backport #3534
backport #3542
backport #3543
backport #3539

Proposed Changes

Fixing issue where jobs do not complete on istio enabled cluster

Release Note

Fixes issue where migration jobs would fail on Istio cluster with auto-inject enabled

knative-prow-robot · 2020-07-09T17:03:56Z

Hi @vayyappaneni. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vayyappaneni · 2020-07-09T17:04:14Z

/assign @markusthoemmes

AceHack · 2020-07-09T17:04:15Z

/ok-to-test

vayyappaneni · 2020-07-09T18:01:50Z

/test pull-knative-eventing-upgrade-tests

AceHack · 2020-07-09T19:21:07Z

/test pull-knative-eventing-upgrade-tests

AceHack · 2020-07-09T19:22:04Z

/test pull-knative-eventing-integration-tests

AceHack · 2020-07-09T21:03:38Z

/test pull-knative-eventing-upgrade-tests

AceHack · 2020-07-09T21:48:31Z

/test pull-knative-eventing-upgrade-tests

pierDipi · 2020-07-10T07:53:56Z

You might want to backport this one first: #3543.

googlebot · 2020-07-10T14:58:22Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

vayyappaneni · 2020-07-10T15:01:49Z

@googlebot I fixed it.

vayyappaneni · 2020-07-10T15:05:48Z

@markusthoemmes @pierDipi @vaikas
I did sign the CLA fews days ago. I am not sure what happen here it is complaining about of CLA . This is what google bot said: #3557 (comment)

googlebot · 2020-07-10T15:10:04Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

AceHack · 2020-07-10T15:11:30Z

This is weird, cherry-picking @vaikas commit cause the CLA to go out of wack. We are gonna just manually make the fix to backport instead of cherry-picking.

mattmoor

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

Co-authored-by: Matt Moore <mattmoor@vmware.com>

vaikas · 2020-07-10T15:19:38Z

I guess I'm little confused what we're backporting here? Shouldn't it just be a rebase? I'm mosdef not a git expert, but something seems wrong here.

vaikas · 2020-07-10T15:20:19Z

lol, I see, you're porting them to .16.1 release :) LOL sorry about the noise...

AceHack · 2020-07-10T15:29:37Z

@vaikas do you know why the CLA got invalidated when we cherry-picked your commit?

vayyappaneni · 2020-07-10T16:22:14Z

/retest

AceHack · 2020-07-10T16:58:22Z

/test pull-knative-eventing-upgrade-tests

vaikas · 2020-07-10T17:35:32Z

@AceHack no idea, in the past I've seen the emails go out of whack when things get cherrypicked, but no idea.

vaikas · 2020-07-10T17:45:10Z

Oh snap, looks like this needs to be cherrypicked also:
#3539

The errors are exactly what we saw in the main branch.

* try to dump some state * use client wait or fail * create broker directly

vayyappaneni · 2020-07-10T21:02:25Z

/retest

AceHack · 2020-07-10T21:13:34Z

@vaikas it seems cherry-picking your PR directly into 16 branch caused unit test issues. Can you offer any advice or do you know if there are other things we should cherry pick.

AceHack · 2020-07-10T21:21:10Z

/retest

vaikas · 2020-07-10T21:35:17Z

Looks like backporting it missed some bits?
https://github.com/knative/eventing/pull/3539/files#diff-9ec464ac1ed01

vs.
https://github.com/knative/eventing/pull/3557/files#diff-9ec464ac1ed0145dae8da5a443e0a903L22

test/upgrade/prober/configuration.go:22:2: imported and not used: "knative.dev/eventing/pkg/reconciler/sugar"

knative-test-reporter-robot · 2020-07-10T21:43:12Z

The following jobs failed:

Test name	Triggers	Retries
pull-knative-eventing-upgrade-tests		0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-upgrade-tests:

test/upgrade.[build failed]

AceHack · 2020-07-11T23:26:20Z

@markusthoemmes @vaikas It's finally working, thanks for all the help. Can we get it merged? Thanks again.

vaikas · 2020-07-12T01:42:10Z

/lgtm
/approve

knative-prow-robot · 2020-07-12T01:42:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas, vayyappaneni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com>

* adding istion annotation (knative#3534) (knative#3557) * adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com> * cp 3897 (knative#3902) * cp 3897 * backport 3719 * x bit * apiserversource v1beta1->v1alpha2 * install broker / sugar * backport 3945 to .16 (knative#3948) Co-authored-by: VijayaSenaReddy Ayyappaneni <48216363+vayyappaneni@users.noreply.github.com> Co-authored-by: Matt Moore <mattmoor@vmware.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>

adding istion annotation (#3534)

08900da

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020

knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2020

knative-prow-robot requested review from matzew and slinkydeveloper July 9, 2020 17:03

knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 9, 2020

knative-prow-robot assigned markusthoemmes Jul 9, 2020

knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 9, 2020

knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 10, 2020

googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 10, 2020

googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 10, 2020

backporting #3543

ca3d6a7

mattmoor reviewed Jul 10, 2020

View reviewed changes

Update test/lib/duck/resource_inspectors.go

480486f

Co-authored-by: Matt Moore <mattmoor@vmware.com>

Use the standard resource creation libs for upgrade tests. (#3539)

2668b90

* try to dump some state * use client wait or fail * create broker directly

knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2020

removed the unused import

0af2464

knative-prow-robot assigned vaikas Jul 12, 2020

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2020

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2020

knative-prow-robot merged commit acdd118 into knative:release-0.16 Jul 12, 2020

vayyappaneni deleted the istiofix-0.16 branch July 12, 2020 04:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding istion annotation (#3534) #3557

adding istion annotation (#3534) #3557

vayyappaneni commented Jul 9, 2020 •

edited

Loading

knative-prow-robot commented Jul 9, 2020

vayyappaneni commented Jul 9, 2020

AceHack commented Jul 9, 2020

vayyappaneni commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

pierDipi commented Jul 10, 2020

googlebot commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020 •

edited

Loading

vayyappaneni commented Jul 10, 2020

googlebot commented Jul 10, 2020

AceHack commented Jul 10, 2020

mattmoor left a comment

vaikas commented Jul 10, 2020

vaikas commented Jul 10, 2020

AceHack commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020

AceHack commented Jul 10, 2020

vaikas commented Jul 10, 2020

vaikas commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020

AceHack commented Jul 10, 2020

AceHack commented Jul 10, 2020

vaikas commented Jul 10, 2020

knative-test-reporter-robot commented Jul 10, 2020

AceHack commented Jul 11, 2020

vaikas commented Jul 12, 2020

knative-prow-robot commented Jul 12, 2020

adding istion annotation (#3534) #3557

adding istion annotation (#3534) #3557

Conversation

vayyappaneni commented Jul 9, 2020 • edited Loading

Proposed Changes

knative-prow-robot commented Jul 9, 2020

vayyappaneni commented Jul 9, 2020

AceHack commented Jul 9, 2020

vayyappaneni commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

AceHack commented Jul 9, 2020

pierDipi commented Jul 10, 2020

googlebot commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020 • edited Loading

vayyappaneni commented Jul 10, 2020

googlebot commented Jul 10, 2020

AceHack commented Jul 10, 2020

mattmoor left a comment

Choose a reason for hiding this comment

vaikas commented Jul 10, 2020

vaikas commented Jul 10, 2020

AceHack commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020

AceHack commented Jul 10, 2020

vaikas commented Jul 10, 2020

vaikas commented Jul 10, 2020

vayyappaneni commented Jul 10, 2020

AceHack commented Jul 10, 2020

AceHack commented Jul 10, 2020

vaikas commented Jul 10, 2020

knative-test-reporter-robot commented Jul 10, 2020

AceHack commented Jul 11, 2020

vaikas commented Jul 12, 2020

knative-prow-robot commented Jul 12, 2020

vayyappaneni commented Jul 9, 2020 •

edited

Loading

vayyappaneni commented Jul 10, 2020 •

edited

Loading