nil check on addressable #3543
Merged
nil check on addressable #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
area/test-and-release
|
The following jobs failed:
Job pull-knative-eventing-upgrade-tests expended all 3 retries without success. |
|
/test pull-knative-eventing-upgrade-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
pushed a commit
that referenced
this pull request
Jul 12, 2020
* adding istion annotation (#3534) * backporting #3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com>
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Sep 30, 2020
* adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com>
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Oct 1, 2020
* adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com>
openshift-merge-robot
pushed a commit
to openshift/knative-eventing
that referenced
this pull request
Oct 7, 2020
* adding istion annotation (knative#3534) (knative#3557) * adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com> * cp 3897 (knative#3902) * cp 3897 * backport 3719 * x bit * apiserversource v1beta1->v1alpha2 * install broker / sugar * backport 3945 to .16 (knative#3948) Co-authored-by: VijayaSenaReddy Ayyappaneni <48216363+vayyappaneni@users.noreply.github.com> Co-authored-by: Matt Moore <mattmoor@vmware.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3540
Proposed Changes
Release Note
Docs