cp 3897 #3902
cp 3897 #3902
Conversation
knative-prow-robot
added
the
size/XS
knative-prow-robot
added
the
approved
|
wat? /test pull-knative-eventing-conformance-tests |
|
/override pull-knative-eventing-conformance-tests |
|
@chizhg: chizhg unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-knative-eventing-conformance-tests |
|
@vaikas: vaikas unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
As discussed here, this is due to change in how the jobs get run. It applies to all the branches and this version does not have the job in there. |
knative-prow-robot
added
size/M
|
Broker didn't become ready, but there are no knative-eventing logs. |
test/e2e-conformance-tests.sh
Outdated
| initialize $@ --skip-istio-addon | ||
|
|
||
| echo "Running tests with Multi Tenant Channel Based Broker" | ||
| go_test_e2e -timeout=30m -parallel=12 ./test/conformance -brokerclass=MTChannelBasedBroker -channels=messaging.knative.dev/v1beta1:Channel,messaging.knative.dev/v1beta1:InMemoryChannel,messaging.knative.dev/v1:Channel,messaging.knative.dev/v1:InMemoryChannel -sources=sources.knative.dev/v1beta1:ApiServerSource,sources.knative.dev/v1alpha2:ContainerSource,sources.knative.dev/v1alpha2:PingSource || fail_test |
There was a problem hiding this comment.
why the difference between source gvk's?
-sources=sources.knative.dev/v1beta1:ApiServerSource,sources.knative.dev/v1alpha2:ContainerSource,sources.knative.dev/v1alpha2:PingSource
vs
-sources=sources.knative.dev/v1alpha2:ApiServerSource,sources.knative.dev/v1alpha2:ContainerSource,sources.knative.dev/v1alpha2:PingSource
There was a problem hiding this comment.
That's what was in the head. Great catch, changed :)
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-conformance-tests: and 6 more. |
is the mt-channel broker yaml being applied? is the controller being brought up? seems weird that all the broker tests (even the tracing ones) are failing with the broker not being created |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, lberk, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* cp 3897 * backport 3719 * x bit * apiserversource v1beta1->v1alpha2 * install broker / sugar
* cp 3897 * backport 3719 * x bit * apiserversource v1beta1->v1alpha2 * install broker / sugar
* adding istion annotation (knative#3534) (knative#3557) * adding istion annotation (knative#3534) * backporting knative#3543 * Update test/lib/duck/resource_inspectors.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * Use the standard resource creation libs for upgrade tests. (knative#3539) * try to dump some state * use client wait or fail * create broker directly * removed the unused import Co-authored-by: Matt Moore <mattmoor@vmware.com> * cp 3897 (knative#3902) * cp 3897 * backport 3719 * x bit * apiserversource v1beta1->v1alpha2 * install broker / sugar * backport 3945 to .16 (knative#3948) Co-authored-by: VijayaSenaReddy Ayyappaneni <48216363+vayyappaneni@users.noreply.github.com> Co-authored-by: Matt Moore <mattmoor@vmware.com> Co-authored-by: Ville Aikas <11279988+vaikas@users.noreply.github.com>
Addresses #3791
When send fails or response is nil, set the response code to 0.
Proposed Changes
Release Note
Docs