Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding istion annotation (#3534) #3557

Merged
merged 5 commits into from
Jul 12, 2020
Merged

adding istion annotation (#3534) #3557

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08900da
adding istion annotation (#3534)
vayyappaneni Jul 9, 2020
ca3d6a7
backporting #3543
vayyappaneni Jul 10, 2020
480486f
Update test/lib/duck/resource_inspectors.go
vayyappaneni Jul 10, 2020
2668b90
Use the standard resource creation libs for upgrade tests. (#3539)
vayyappaneni Jul 8, 2020
0af2464
removed the unused import
vayyappaneni Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/post-install/v0.15.0/storage-version-migration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ spec:
metadata:
labels:
app: "storage-version-migration"
annotations:
sidecar.istio.io/inject: "false"
spec:
serviceAccountName: knative-eventing-post-install-job
restartPolicy: OnFailure
Expand Down
8 changes: 5 additions & 3 deletions config/pre-install/v0.16.0/storage-version-migration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,20 @@
apiVersion: batch/v1
kind: Job
metadata:
name: storage-version-migration-v016
name: storage-version-migration-eventing
namespace: knative-eventing
labels:
app: "storage-version-migration"
app: "storage-version-migration-eventing"
eventing.knative.dev/release: devel
spec:
ttlSecondsAfterFinished: 600
backoffLimit: 10
template:
metadata:
labels:
app: "storage-version-migration"
app: "storage-version-migration-eventing"
annotations:
sidecar.istio.io/inject: "false"
spec:
serviceAccountName: knative-eventing-pre-install-job
restartPolicy: OnFailure
Expand Down
4 changes: 4 additions & 0 deletions test/lib/duck/resource_inspectors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ func GetAddressableURI(dynamicClient dynamic.Interface, obj *resources.MetaResou

at := untyped.(*duckv1alpha1.AddressableType)

if at.Status.Address == nil {
return url.URL{}, fmt.Errorf("addressable does not have an Address: %+v", at)
}

au := at.Status.Address.GetURL()
if au.Host == "" {
return url.URL{}, fmt.Errorf("addressable's URL does not have a Host: %+v", at)
Expand Down