-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] We should have sources.knative.dev #1500
Comments
Yes, that makes sense to me, @n3wscott ! |
sources.knative.dev it is. |
late to the party... but still... +1 |
I’m against this change. Sources.knative.dev has no clear connection with eventing and could be connected with source code, build, and/or FaaS scenarios in the future if the project moves that way. I understand the desire to have a shorter string, but you need a connection to what kind of sources your talking about. |
@rgregg do you have other suggestions? It is possible to use these sources without using eventing (or messaging) constructs. I get what you're saying about reasons to not call it sources, but we didn't have anyone bring forward other options. |
From the context above, the problem was "string length". If that's the only problem we're trying to solve, I think we should punt completely and keep "sources.eventing.knative.dev". The primary use case for sources is with eventing, is it not? I'm struggling to imagine advanced use cases where you wouldn't use them with scenarios focused on "eventing" even if you aren't using the whole eventing framework. Should there be non-event based use cases for these sources, or would that belong in a different place so that we can keep these sources focused on a primary use-case and not over extend them? |
Here is my thinking, I am attempting to define the internal brands inside of Knative.
So asking a user to use sources.eventing.knative.dev to me means you need to use eventing to make sources work, and it does not tell them it is ok to 1) use it independently; and 2) it plays with the other components in the Knative eco-system. I did not add this context to the description, but this is the thought process. I will add it now. |
I'm convinced. |
What about src-eventing.knative.dev - what is length limit? |
TODO:
|
@n3wscott can this be closed? |
All linked issues/PRs have been closed or merged. I'm calling this one done but please reopen if not. /close |
@grantr: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> Co-authored-by: Ahmed Abdalla <aabdelre@redhat.com>
sources.eventing.knative.dev
is too long and should not include eventing. I think we should move the resources tosources.knative.dev
Thoughts?
Update:
Here is my thinking, I am attempting to define the internal brands inside of Knative.
So asking a user to use sources.eventing.knative.dev to me means you need to use eventing to make sources work, and it does not tell them it is ok to 1) use it independently; and 2) it plays with the other components in the Knative eco-system.
The text was updated successfully, but these errors were encountered: