Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SinkBinding to sources.knative.dev #2369

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Add SinkBinding to sources.knative.dev #2369

merged 3 commits into from
Jan 10, 2020

Conversation

n3wscott
Copy link
Contributor

Related to #1500

Proposed Changes

  • Add in a controller for the new SinkBinding under sources.knative.dev

Release Note

New resource added: SinkBinding under sources.knative.dev

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 10, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 10, 2020
@n3wscott
Copy link
Contributor Author

/assign @vaikas

@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2020
@n3wscott n3wscott mentioned this pull request Jan 10, 2020
Merged
@mikehelmick
Copy link
Contributor

please take a look at the failed integration tests

@n3wscott
Copy link
Contributor Author

/retest

@vaikas
Copy link
Contributor

vaikas commented Jan 10, 2020

/test pull-knative-eventing-integration-tests

@n3wscott
Copy link
Contributor Author

hmmmmm looking into it

@n3wscott
Copy link
Contributor Author

I think I found the issue, there was a missing rbac that I did not dup. Fixed.

@n3wscott
Copy link
Contributor Author

/retest

only one of the legacy tests failed... retry

@vaikas
Copy link
Contributor

vaikas commented Jan 10, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4f214a8 into knative:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrcunha adrcunha Awaiting requested review from adrcunha

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @mikehelmick @vaikas @knative-prow-robot @googlebot