-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] moving to sources.knative.dev for source api group. #2310
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
We should do the same we did with sequence/parallel, create the new group, mark these as deprecated and let them go for 2 releases so folks can migrate them. |
The following is the coverage report on the affected files.
|
@@ -36,7 +36,11 @@ required = [ | |||
# Our master branch tracks knative/pkg master or a release. | |||
[[override]] | |||
name = "knative.dev/pkg" | |||
branch = "master" | |||
# TODO: PoC for generator import. DO NOT SUBMIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found "DO NOT SUBMIT".
@n3wscott: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
@n3wscott: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Relates to #1500
Proposed Changes
sources.eventing.knative.dev
tosources.knative.dev
Reasoning:
Release Note