Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] moving to sources.knative.dev for source api group. #2310

Closed
wants to merge 6 commits into from

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Dec 12, 2019

Relates to #1500

Proposed Changes

  • Move sources.eventing.knative.dev to sources.knative.dev

Reasoning:

  • Eventing brand is event based mesh-like interactions. Sources are not this.
  • Messaging is point to point persistence delivery. Sources are also not this.
  • Flows are routing. Sources do not do this.
  • Sources are event producing resources.

Release Note

Resources that used to be under sources.eventing.knative.dev are now moved to  sources.knative.dev. No other functional changes.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 12, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Dec 12, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@n3wscott
Copy link
Contributor Author

/hold
hold for a question about migrations.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@vaikas
Copy link
Contributor

vaikas commented Dec 12, 2019

We should do the same we did with sequence/parallel, create the new group, mark these as deprecated and let them go for 2 releases so folks can migrate them.

@n3wscott n3wscott changed the title moving to sources.knative.dev for source api group. [WIP] moving to sources.knative.dev for source api group. Dec 13, 2019
@knative-prow-robot knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/legacysources/v1alpha1/apiserver_types.go Do not exist 0.0%
pkg/apis/legacysources/v1alpha1/containersource_types.go Do not exist 0.0%
pkg/apis/legacysources/v1alpha1/cron_job_types.go Do not exist 0.0%
pkg/apis/legacysources/v1alpha1/register.go Do not exist 100.0%
pkg/apis/legacysources/v1alpha1/sinkbinding_types.go Do not exist 0.0%
pkg/apis/sources/v1alpha1/cron_job_types.go 66.7% 50.0% -16.7
pkg/apis/sources/v1alpha1/sinkbinding_types.go Do not exist 0.0%
pkg/legacyreconciler/apiserversource/apiserversource.go Do not exist 78.5%
pkg/legacyreconciler/apiserversource/cfg_host.go Do not exist 83.3%
pkg/legacyreconciler/apiserversource/controller.go Do not exist 94.1%
pkg/legacyreconciler/containersource/resources/deployment.go Do not exist 100.0%

@@ -36,7 +36,11 @@ required = [
# Our master branch tracks knative/pkg master or a release.
[[override]]
name = "knative.dev/pkg"
branch = "master"
# TODO: PoC for generator import. DO NOT SUBMIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found "DO NOT SUBMIT".

@knative-prow-robot
Copy link
Contributor

@n3wscott: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-integration-tests 420150a link /test pull-knative-eventing-integration-tests
pull-knative-eventing-unit-tests 420150a link /test pull-knative-eventing-unit-tests
pull-knative-eventing-build-tests 420150a link /test pull-knative-eventing-build-tests
pull-knative-eventing-go-coverage 420150a link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@n3wscott
Copy link
Contributor Author

n3wscott commented Jan 7, 2020

/close

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants