Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify v1Beta1 API candidates and potential gaps #1869

Closed
akashrv opened this issue Sep 11, 2019 · 18 comments
Closed

Identify v1Beta1 API candidates and potential gaps #1869

akashrv opened this issue Sep 11, 2019 · 18 comments
Assignees
Labels
Epic Epics to group issues kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal/0.12 Proposed (not planned) work items for 0.12 release
Milestone

Comments

@akashrv
Copy link
Contributor

akashrv commented Sep 11, 2019

Problem
We need to figure out v1beta1 api surface for Knative Eventing. We could either start moving stable apis to v1beta1, or identify a minimum set of apis that make sense to promote together to v1beta1 and identify what is missing so that we can target to fill the gaps in v0.10 and promote to v1beta1 in v0.11

Exit Criteria

  • Identify minimal set of APIs that will be part of v1beta1 api surface
  • Identify what is missing for each construct and have issues
  • Target v1beta1 apis in or before v0.11
@akashrv
Copy link
Contributor Author

akashrv commented Sep 11, 2019

/milestone v0.10
/assign @matzew @vaikas-google

@lionelvillard
Copy link
Member

I would add

  • identity what needs to be cleaned up/tuned in the minimal set of APIs

For instance

  • channel.spec.subscribable.subscribers -> channel.spec.subscribers (if possible)
  • subscription.spec.subscriber.ref -> channel.spec.subscriber

@akashrv
Copy link
Contributor Author

akashrv commented Sep 16, 2019

/milestone v0.10.0

@knative-prow-robot knative-prow-robot added this to the v0.10.0 milestone Sep 16, 2019
@matzew
Copy link
Member

matzew commented Sep 17, 2019

documentation should be one a criteria as well

@aslom
Copy link
Member

aslom commented Sep 17, 2019

As we make those decisions maybe we could also document criteria and how we version APIs - and add to knative docs?

@matzew
Copy link
Member

matzew commented Sep 19, 2019

@akashrv I think I will start a document like this: https://docs.google.com/document/d/149LMccHt-gFEG52XoauVG2f-crjMk3-biu-pJPQGxCo/edit

I think that serving did well w/ their APIs, so I guess this is good for eventing too

@akashrv
Copy link
Contributor Author

akashrv commented Sep 19, 2019 via email

@akashrv akashrv modified the milestones: v0.10.0, v0.10.0-M2 Oct 4, 2019
@akashrv akashrv added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 4, 2019
@paulrossman paulrossman added the Epic Epics to group issues label Oct 8, 2019
@akashrv
Copy link
Contributor Author

akashrv commented Oct 15, 2019

related to #1976

@akashrv
Copy link
Contributor Author

akashrv commented Oct 15, 2019

@matzew @vaikas-google Were you able to make any progress on this? Given we have just 2 weeks left for v10 milestone, shall we prioritize this work?

@mikehelmick
Copy link
Contributor

Since we're still making API changes in v10 that haven't landed yet (destination), I think that rushing beta API version in the next 2 weeks probably isn't the best idea. If we're happy with the changes that are going in, perhaps a v1beta1 candidate for v11 is more realistic.

We added an item to the WG agenda for this week to discuss a task force to solidify this API. We did this for knative serving several months ago and that process worked well.

@vaikas
Copy link
Contributor

vaikas commented Oct 15, 2019

We're still trying to distill what the changes are, once we figure them out, then it would be useful to understand in the context of the actual Deltas to see how likely things are to land or not.

@matzew
Copy link
Member

matzew commented Oct 15, 2019

I agree. In the channel task force we spoke about parts of messaging APIs (e.g. Channel, Subscription, and IMC (as default impl)), but now there are coming changes to at least Subscription, or they are being discussed.

Between 0.10 and 0.11 we should see that we get a list, to be promoted by 0.12 or 0.13 ?

@matzew
Copy link
Member

matzew commented Oct 15, 2019 via email

@akashrv
Copy link
Contributor Author

akashrv commented Oct 15, 2019

#1134

@vaikas
Copy link
Contributor

vaikas commented Oct 15, 2019

#1500

@n3wscott
Copy link
Contributor

I will join. I like APIs.

@akashrv akashrv modified the milestones: v0.10.0-M2, v0.10.0 Oct 17, 2019
@devguyio
Copy link
Contributor

@matzew @vaikas-google would like to join the taskforce

@paulrossman paulrossman modified the milestones: v0.10.0, v0.11.0-M1 Oct 30, 2019
@paulrossman paulrossman removed this from the v0.11.0-M1 milestone Nov 21, 2019
@paulrossman paulrossman added this to the v0.11.0-M2 milestone Nov 21, 2019
@grantr grantr modified the milestones: v0.11.0-M2, v0.11.0 Nov 26, 2019
@vaikas vaikas added the proposal/0.12 Proposed (not planned) work items for 0.12 release label Dec 10, 2019
@akashrv akashrv modified the milestones: v0.11.0, v0.12.0, v0.12.0-M1 Dec 10, 2019
@grantr
Copy link
Contributor

grantr commented Jan 13, 2020

/milestone v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Epics to group issues kind/feature-request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. proposal/0.12 Proposed (not planned) work items for 0.12 release
Projects
None yet
Development

No branches or pull requests