Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventtypes v1beta1 #2466

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Eventtypes v1beta1 #2466

merged 5 commits into from
Jan 30, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jan 29, 2020 •
edited
Loading

addresses #1869

Proposed Changes

  • Move eventtypes as is to v1beta1. One change is two fiels, source/schema were specified as URI fields, but type was string, so changes those to apis.URL.

Release Note

NONE just the types.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 29, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2020
@vaikas vaikas changed the title [WIP] Eventtypes v1beta1 Eventtypes v1beta1 Jan 30, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2020
@n3wscott
Copy link
Contributor

/lgtm
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1beta1/eventtype_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1beta1/eventtype_types.go Do not exist 0.0%
pkg/apis/eventing/v1beta1/eventtype_validation.go Do not exist 95.0%

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Jan 30, 2020 •
edited
Loading

@vaikas: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage fd064d8 link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@knative-prow-robot knative-prow-robot merged commit 4024c83 into knative:master Jan 30, 2020
@vaikas vaikas deleted the eventtypes-v1beta1 branch January 30, 2020 17:38
@vaikas vaikas mentioned this pull request Feb 25, 2020
Closed
@nachocano nachocano mentioned this pull request Mar 6, 2020
Closed
@matzew matzew mentioned this pull request Apr 27, 2023
Merged
knative-prow bot pushed a commit that referenced this pull request Apr 28, 2023
@matzew
EventType v1b2 API addition (#6893)
7f4deb5 
Fixes #6887

Following the pattern from
[here](#2466), by just adding
the types

<!-- Please include the 'why' behind your changes if no issue exists -->

## Proposed Changes

<!-- Please categorize your changes:
- 🎁 Add new feature
- 🐛 Fix bug
- 🧹 Update or clean up current behavior
- 🗑️ Remove feature or internal logic
-->

- adding just `v1beta2` api for `EventType`

**Release Note**

<!--
📄 If this change has user-visible impact, write a release
note in the block
below. Include the string "action required" if additional action is
required of
users switching to the new release, for example in case of a breaking
change.

Write as if you are speaking to users, not other Knative contributors.
If this
change has no user-visible impact, no release note is needed.
-->

```release-note
```

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @knative-prow-robot @n3wscott @knative-metrics-robot @googlebot