This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Reverting Baremetal changes to avoid breaking Baremetal changes #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
changed the title
iaguis
approved these changes
Mar 11, 2021
|
Did the release testing for bare-metal again on this branch and it went smooth, this can be merged in! |
ipochi
added a commit
that referenced
this pull request
Jun 3, 2021
…remetal-changes Revert "Merge pull request #1426 (Baremetal changes that were reverted)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverses the baremetal changes introduced for baremetal platform to avoid an overly complex update procedure.
The following PRs are reverted:
baremetal: use controller and worker module #1374
Create separate module named
matchbox-flatcarthat provisions flatcar only. #1387tinkerbell: pass cluster_name to worker module #1398
baremetal : new feature node_specific_labels for adding node specific labels. #1405
TODO (post 0.7.0 release)
The plan for these PRs to be included in the master branch is to first implement certificate rotation strategy ( Implement automatic certificate rotation #1201 ), this should result in a slightly messier update process.