Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

baremetal : new feature node_specific_labels for adding node specific labels. #1405

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

ipochi
Copy link
Member

@ipochi ipochi commented Feb 25, 2021

This PR introduces a new field in Baremetal configuration named
node_specific_labels.

This feature adds the ability to provide specific set of labels unique
to the node.

Signed-off-by: Imran Pochi imran@kinvolk.io

@ipochi ipochi force-pushed the imran/baremetal-node-specific-labels branch from 3dc6264 to b237002 Compare February 25, 2021 13:36
@ipochi ipochi force-pushed the imran/baremetal-node-specific-labels branch 2 times, most recently from d50e74b to 5e95e3c Compare March 8, 2021 12:01
@ipochi ipochi changed the title WIP - do not review; baremetal : node-specific labels baremetal : new feature node_specific_labels for adding node specifi labels. Mar 8, 2021
@ipochi ipochi changed the title baremetal : new feature node_specific_labels for adding node specifi labels. baremetal : new feature node_specific_labels for adding node specific labels. Mar 8, 2021
@ipochi ipochi force-pushed the imran/baremetal-node-specific-labels branch from 5e95e3c to f5f9248 Compare March 8, 2021 12:16
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good, I have some suggestions we could apply.

pkg/platform/baremetal/baremetal.go Outdated Show resolved Hide resolved
pkg/platform/baremetal/template.go Outdated Show resolved Hide resolved
This commit introduces a new field in Baremetal configuration named
`node_specific_labels`.

This feature adds the ability to provide specific set of labels unique
to the node.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi force-pushed the imran/baremetal-node-specific-labels branch from 3fb55ce to 9a1013a Compare March 9, 2021 10:16
@ipochi ipochi requested review from invidian and knrt10 March 9, 2021 10:39
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ipochi ipochi merged commit a495c72 into master Mar 9, 2021
@ipochi ipochi deleted the imran/baremetal-node-specific-labels branch March 9, 2021 11:42
ipochi added a commit that referenced this pull request Mar 11, 2021
…ecific-labels"

This reverts commit a495c72, reversing
changes made to 0736a32.

Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi added a commit that referenced this pull request Jun 1, 2021
…al-changes"

This reverts commit 106ea42, reversing
changes made to ac85cbb.

In effect this PR wants to re-revert the revert and put the following
baremetal changes back into master:
- #1374
- #1387
- #1398
- #1405
ipochi added a commit that referenced this pull request Jun 1, 2021
…al-changes"

This reverts commit 106ea42, reversing
changes made to ac85cbb.

In effect this PR wants to re-revert the revert and put the following
baremetal changes back into master:
- #1374
- #1387
- #1398
- #1405
ipochi added a commit that referenced this pull request Jun 2, 2021
…al-changes"

This reverts commit 106ea42, reversing
changes made to ac85cbb.

In effect this PR wants to re-revert the revert and put the following
baremetal changes back into master:
- #1374
- #1387
- #1398
- #1405
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants