This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
baremetal : new feature node_specific_labels for adding node specific labels. #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
imran/baremetal-node-specific-labels
branch
from
February 25, 2021 13:36
3dc6264
to
b237002
Compare
ipochi
force-pushed
the
imran/baremetal-node-specific-labels
branch
2 times, most recently
from
March 8, 2021 12:01
d50e74b
to
5e95e3c
Compare
ipochi
changed the title
WIP - do not review; baremetal : node-specific labels
baremetal : new feature node_specific_labels for adding node specifi labels.
Mar 8, 2021
ipochi
changed the title
baremetal : new feature node_specific_labels for adding node specifi labels.
baremetal : new feature node_specific_labels for adding node specific labels.
Mar 8, 2021
ipochi
force-pushed
the
imran/baremetal-node-specific-labels
branch
from
March 8, 2021 12:16
5e95e3c
to
f5f9248
Compare
knrt10
suggested changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/variables.tf
Outdated
Show resolved
Hide resolved
invidian
suggested changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking good, I have some suggestions we could apply.
This commit introduces a new field in Baremetal configuration named `node_specific_labels`. This feature adds the ability to provide specific set of labels unique to the node. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/baremetal-node-specific-labels
branch
from
March 9, 2021 10:16
3fb55ce
to
9a1013a
Compare
invidian
approved these changes
Mar 9, 2021
knrt10
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new field in Baremetal configuration named
node_specific_labels
.This feature adds the ability to provide specific set of labels unique
to the node.
Signed-off-by: Imran Pochi imran@kinvolk.io