This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
tinkerbell: pass cluster_name to worker module #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
previously approved these changes
Feb 24, 2021
|
@ipochi maybe try pushing again, probably tinkerbell picks it up this time? |
ipochi
force-pushed
the
imran/tinkerbell-fix-pass-cluster-name-to-worker-module
branch
from
69af1a4 to
eb6576a
Compare
I repushed the PR, didnt trigger the pipeline. |
This commit fixes a regression that came about when `cluster_name` variable was added to the generic `worker` module in this commit ee39dab. Since it is a required variable, tinkerbell ci failed. This commit fixes the above issue, by passing the `cluster_name` to the worker module. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/tinkerbell-fix-pass-cluster-name-to-worker-module
branch
from
eb6576a to
0588561
Compare
invidian
approved these changes
Mar 9, 2021
surajssd
approved these changes
Mar 9, 2021
knrt10
approved these changes
Mar 9, 2021
ipochi
deleted the
imran/tinkerbell-fix-pass-cluster-name-to-worker-module
branch
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression that came about when
cluster_namevariable was added to the generic
workermodule in this commitee39dab.
Since it is a required variable, tinkerbell ci failed.
This commit fixes the above issue, by passing the
cluster_nameto theworker module.
Failed CI build : https://yard.lokomotive-k8s.net/teams/main/pipelines/master-tinkerbell/jobs/test-lokomotive-deployment/builds/43
Signed-off-by: Imran Pochi imran@kinvolk.io