This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Create separate module named matchbox-flatcar that provisions flatcar only.
#1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
8 times, most recently
from
ec67d43 to
04bed78
Compare
ipochi
changed the title
matchbox-flatcar that provisions flatcar only.
invidian
previously approved these changes
Feb 23, 2021
assets/terraform-modules/bare-metal/flatcar-linux/kubernetes/ssh.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/matchbox-flatcar/templates/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
assets/terraform-modules/matchbox-flatcar/templates/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
from
04bed78 to
361aae2
Compare
invidian
previously approved these changes
Feb 23, 2021
assets/terraform-modules/matchbox-flatcar/templates/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
from
361aae2 to
7375a58
Compare
invidian
previously approved these changes
Feb 24, 2021
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
2 times, most recently
from
cce51f9 to
7899f02
Compare
invidian
previously approved these changes
Feb 25, 2021
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
from
7899f02 to
fde1113
Compare
This commit restructures the baremetal terraform module to split the flatcar provisioning as a separate module `matchbox-flatcar`. The new module takes care of setting up matchbox profiles and groups. This makes it much easier to use this new module for other projects and possibly the matchbox-flatcar module could maybe live in its own repository in the future. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/split-baremetal-for-plain-flatcar-provisioning
branch
from
fde1113 to
15285e0
Compare
invidian
approved these changes
Mar 9, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a new module named
matchbox-flatcarwhich does the flatcar provisioning. Removes the code from baremetal and makes change s such that baremetal uses the new module.Contains commits from #1374.
Please only review this commit 04bed78