Add jupyter/julia-notebook #1926

yuvipanda · 2023-06-26T22:21:26Z

Describe your changes

There is a growing number of Julia users in the Jupyter ecosystem who do not use R, and hence would <3 to have a dedicated docker image that doesn't bring in all the R stuff that datascience-notebook brings in! The built image size is much smaller, and eventually paves the way to better ecosystem support for Julia.

Checklist (especially for first-time contributors)

I have performed a self-review of my code
If it is a core feature, I have added thorough tests
I will try not to use force-push to make the review process easier for reviewers
I have updated the documentation for significant changes

There is a growing number of Julia users in the Jupyter ecosystem who do not use R, and hence would <3 to have a dedicated docker image that doesn't bring in all the R stuff that datascience-notebook brings in! The built image size is much smaller, and eventually paves the way to better ecosystem support for Julia.

for more information, see https://pre-commit.ci

yuvipanda · 2023-06-27T02:12:32Z

This image is 2.2GB, vs the datascience-notebook being 5.83GB!

mathbunnyru · 2023-06-27T08:29:10Z

Docs failing is fine.
Pre-commit mypy error is valid though:

tests/julia-notebook/test_julia.py: error: Duplicate module named "test_julia" (also at "tests/datascience-notebook/test_julia.py"

mathbunnyru

There are a few things I would like to ask you to do:

In places, where images were sorted by name, let's keep them sorted.
In other places, let's put julia-notebook after r-notebook.
Please, update the Makefile
And also, inheritance diagram

I also think, that it makes sense to put Julia installation in a bash script and to add it to base-notebook and then we will just run it in some images. This will allow us to reduce code duplication. This can be done in a separate PR later though, to make it easier for you.

.github/ISSUE_TEMPLATE/bug_report.yml

.github/ISSUE_TEMPLATE/feature_request.yml

julia-notebook/README.md

yuvipanda · 2023-06-27T19:18:18Z

Thanks for the quick review, @mathbunnyru! I have addressed everything except the inheritance diagram! Do you have a tool suggestion on what I can use to edit that?

for more information, see https://pre-commit.ci

mathbunnyru · 2023-06-27T20:54:40Z

@yuvipanda take a look at the markdown, it's not just an SVG image, but also a link where you can change the diagram easily, generate new permanent link and download an image as a new SVG.
http://interactive.blockdiag.com/?compression=deflate&src=eJyFjjFuwzAMRXefgvDUDDpAYaQnyNaOBQraphPCCmlIFIy0yN0rdQggI4XX9x__Z-91mEfGM_w0ACNNmLx9TSoW-ZvgCK9d5hqYxNBYJaNFgwVk65octalPYulTXk4f77CyXXLOYhDIE0Y6tODeYMwrFFw0HOboJk0y_rWV8v-yctfnBidq1KvORa5AMa4sfEVfSVtWvDjwcqusmhSnNZKoYfK6Pnj7XM0vYqYkA-1Oh53Z5RYXDHNlbVnx0Hu3Ne-_7MWcxg

mathbunnyru

A few places left to sort, but looks good to me 👍

mathbunnyru · 2023-06-27T20:56:35Z

.github/workflows/docker.yml

+  aarch64-julia:
+    uses: ./.github/workflows/docker-build-test-upload.yml
+    with:
+      parentImage: minimal-notebook
+      image: julia-notebook
+      platform: aarch64
+      runsOn: ARM64
+    needs: [aarch64-minimal]
+    if: github.repository == 'jupyter/docker-stacks'
+
+  x86_64-julia:
+    uses: ./.github/workflows/docker-build-test-upload.yml
+    with:
+      parentImage: minimal-notebook
+      image: julia-notebook
+      platform: x86_64
+      runsOn: ubuntu-latest
+    needs: [x86_64-minimal]
+


This section should be after the r-notebook section.

.github/workflows/docker.yml

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

yuvipanda · 2023-06-27T22:40:48Z

That's very helpful, @mathbunnyru! I think I've addressed them now.

mathbunnyru · 2023-06-28T10:43:39Z

@yuvipanda I added a new repository to the DockerHub and merged your PR (that's all I had to do manually, even description will be pushed automatically to DockerHub 🙂).

I didn't congratulate you with the first PR to this repo, so let me congratulate you with the second one ❤️

mathbunnyru · 2023-06-28T10:44:52Z

https://hub.docker.com/r/jupyter/julia-notebook

Images should be updated in ~2 hours.

yuvipanda · 2023-06-28T18:40:52Z

AMAZING, THANK YOU SO MUCH @mathbunnyru!

The datascience notebook was added primarily to support Julia. We have worked with upstream to add a julia specific notebook (jupyter/docker-stacks#1926), so we use the Julia notebook now!

mathbunnyru · 2023-06-28T18:50:29Z

AMAZING, THANK YOU SO MUCH @mathbunnyru!

You're welcome:)

If you have some spare time, it would be great to have a Julia installation script put to jupyter/minimal-notebook, so we don't duplicate big chunks of code in Dockerfiles.

mathbunnyru · 2023-07-25T20:16:00Z

.github/workflows/docker.yml

@@ -254,6 +275,7 @@ jobs:
            minimal-notebook,
            scipy-notebook,
            r-notebook,
+            julia-notebook,


We forgot to add a new julia dependency in needs: in a few lines below.

mathbunnyru · 2023-07-25T20:16:05Z

.github/workflows/docker.yml

@@ -290,6 +312,7 @@ jobs:
            minimal-notebook,
            scipy-notebook,
            r-notebook,
+            julia-notebook,


We forgot to add a new julia dependency in needs: in a few lines below.

mathbunnyru · 2023-07-25T20:18:58Z

@yuvipanda I left these comments because I use this image as an example of how a new image can be added.
If you can, please cherry-pick or manually add this commit to your branch (so, this PR will be 100% correct).
If not, just ignore this message 🙂

yuvipanda · 2023-07-25T20:35:36Z

@mathbunnyru that's so sweet! I've cherry-picked that commit but it doesn't seem to be reflected here.

mathbunnyru · 2023-07-25T20:39:46Z

Thanks @yuvipanda
It seems to be GitHub limitations, so we can't do anything here, unfortunately.
Thanks for trying 🙂

* Add jupyter/julia-notebook There is a growing number of Julia users in the Jupyter ecosystem who do not use R, and hence would <3 to have a dedicated docker image that doesn't bring in all the R stuff that datascience-notebook brings in! The built image size is much smaller, and eventually paves the way to better ecosystem support for Julia. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add a test for julia-notebook * Tell tests what julia-notebook inherits from * Sort lists with julia-notebook * Fix README for julia-notebook * Add julia-notebook to the makefile * Move julia-notebook below r-notebook * Use hard tabs in Makefile * Do some more sorting * Rename test_julia to avoid mypy issue * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Re-order julia/r-notebook Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com> * Move julia-notebook stanza under r-notebook * Update inheritance diagram --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

yuvipanda and others added 4 commits June 26, 2023 15:17

[pre-commit.ci] auto fixes from pre-commit.com hooks

0606052

for more information, see https://pre-commit.ci

Add a test for julia-notebook

03e1726

Tell tests what julia-notebook inherits from

1c8cd3e

mathbunnyru requested changes Jun 27, 2023

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved

.github/ISSUE_TEMPLATE/feature_request.yml Outdated Show resolved Hide resolved

julia-notebook/README.md Outdated Show resolved Hide resolved

yuvipanda added 7 commits June 27, 2023 12:11

Sort lists with julia-notebook

02f37c5

Fix README for julia-notebook

3b12edd

Add julia-notebook to the makefile

1956c10

Move julia-notebook below r-notebook

c34ce42

Use hard tabs in Makefile

59698ca

Do some more sorting

e9a1a24

Rename test_julia to avoid mypy issue

ba13383

[pre-commit.ci] auto fixes from pre-commit.com hooks

952193b

for more information, see https://pre-commit.ci

mathbunnyru requested changes Jun 27, 2023

View reviewed changes

yuvipanda and others added 3 commits June 27, 2023 15:11

Re-order julia/r-notebook

013137e

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>

Move julia-notebook stanza under r-notebook

1956521

Update inheritance diagram

0caeb95

yuvipanda marked this pull request as ready for review June 27, 2023 22:19

mathbunnyru merged commit a489a0f into jupyter:main Jun 28, 2023

yuvipanda mentioned this pull request Jun 28, 2023

Use new upstream Julia notebook for JMTE 2i2c-org/infrastructure#2740

Merged

yuvipanda mentioned this pull request Jun 28, 2023

Add a setup script to install Julia + IJulia #1927

Merged

4 tasks

twalcari mentioned this pull request Jul 6, 2023

Add jupyter/pytorch-notebook #1936

Merged

4 tasks

mathbunnyru reviewed Jul 25, 2023

View reviewed changes

consideRatio mentioned this pull request Aug 8, 2023

Policy on adding new images #1958

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add jupyter/julia-notebook #1926

Add jupyter/julia-notebook #1926

yuvipanda commented Jun 26, 2023

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 27, 2023

mathbunnyru left a comment

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 27, 2023

mathbunnyru left a comment

mathbunnyru Jun 27, 2023

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 28, 2023

mathbunnyru commented Jun 28, 2023

yuvipanda commented Jun 28, 2023

mathbunnyru commented Jun 28, 2023

mathbunnyru Jul 25, 2023

mathbunnyru Jul 25, 2023

mathbunnyru commented Jul 25, 2023 •

edited

Loading

yuvipanda commented Jul 25, 2023

mathbunnyru commented Jul 25, 2023

Add jupyter/julia-notebook #1926

Add jupyter/julia-notebook #1926

Conversation

yuvipanda commented Jun 26, 2023

Describe your changes

Checklist (especially for first-time contributors)

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 27, 2023

mathbunnyru left a comment

Choose a reason for hiding this comment

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 27, 2023

mathbunnyru left a comment

Choose a reason for hiding this comment

mathbunnyru Jun 27, 2023

Choose a reason for hiding this comment

yuvipanda commented Jun 27, 2023

mathbunnyru commented Jun 28, 2023

mathbunnyru commented Jun 28, 2023

yuvipanda commented Jun 28, 2023

mathbunnyru commented Jun 28, 2023

mathbunnyru Jul 25, 2023

Choose a reason for hiding this comment

mathbunnyru Jul 25, 2023

Choose a reason for hiding this comment

mathbunnyru commented Jul 25, 2023 • edited Loading

yuvipanda commented Jul 25, 2023

mathbunnyru commented Jul 25, 2023

mathbunnyru commented Jul 25, 2023 •

edited

Loading