-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy on adding new images #1958
Comments
Thanks @consideRatio. This is really helpful. |
So, I have a list of a few things we should consider when adding new images (I also express my own opinion here and people might disagree with it and it's ok):
|
The message above is my opinion (which might easily change) and not a statement 🙂 |
With regards to point 5: adding GPU-support is non-trivial because the version of CUDA that you bundle is an extra confounding factor. For example, PyTorch has separate package indexes for CUDA 11.7 and 11.8. Do you bundle cuDDN or not? When the version of CUDA bundled into the docker image is newer than what's supported by the Nvidia drivers on the host system, it will crash, etc. |
Thanks, @twalcari, that's a good point. I think we need a way to build all the images tree in parallel. For example, we can build the images tree with simple Ubuntu (as now), and also build the images tree for cuda 11.7 (and add some tag prefix like So, if someone wants to add templating based on the root image, even without adding gpu-support, it seems to be a nice feature to have. We will also have to take a look at licensing of cuda-based images, I think one of the reasons they were not added was not being able to redistribute the images because of the cuda license (I'm not sure about this one). |
It would be nice to come up with a policy when we add new images and when we don't.
#1936
Another question is - do we allow ourselves to remove some images (stop building new versions) for some image.
The text was updated successfully, but these errors were encountered: