-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base notebook stack #209
Base notebook stack #209
Conversation
3409e56
to
57fd28e
Compare
@parente How much space does it add for vim and git? On another note, have you tried Alpine yet? While I believe we should have a Debian tiny, it might be worth playing around with this at some point. It may be helpful for Raspberry Pi and education. |
Will check.
I tried alpine at one point. It's tens of MB smaller to start, but once you lob in miniconda and such, the savings over debian really doesn't matter much in the desktop / cloud realm. That said, for new use cases, I agree another micro stack might still make sense. |
@willingc, with git and vim:
Nearly 100 MB increase. I think they should be excluded here since they're not required dependencies for the jupyter components to work. |
@parente agreed. Thanks for checking. |
I do feel a bit odd having tiny < minimal. If I had my druthers, I'd rename 'minimal' to 'base' or 'basic' and then have 'minimal' be the truly minimal stack, but I don't know who might be relying on minimal being not-so-minimal.
Installing JupyterHub is not required to get the single-user script. In particular, it pulls in unused dependencies. This could be simplified to just fetch the script directly:
|
I agree the naming is not a great idea, but I'm worried about the ~5000 pulls of the minimal-notebook: https://gist.github.com/parente/316d5c242aeb484484c8 I'd certainly be peeved if one day I decided to go with the latest minimal-notebook and found that it changed from "minimal image with a fully functioning notebook to get work done" to "minimal image with a minimally functioning notebook for use as a base image". Maybe this new image should be called base-notebook, since it is at the top of the hierarchy and is meant to serve as a base Docker image, and minimal-notebook stays as is?
Yes, except @jtyberg felt yanking one file out of GitHub felt messy in the original PR (#185 (comment)). |
@willingc I'll definitely update the inheritance diagram in the root README once we settle on the names. |
Fantastic, it's looking really good now! Outstanding, thanks :-) |
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
(c) Copyright IBM Corp. 2016
Rebased. I think this can go in now. |
Starting the build for this. |
Getting anaconda over capacity and |
fix parsing of dict env variables
Continuing the discussion from #205. Not ready to merge. Includes #208 for most up to date size comparison.
With this definition, tiny-notebook is about ~1/5th the size of minimal-notebook.
Decisions for discussion:
Other notes: