Add PHP Stack #444
Add PHP Stack #444
Conversation
php-notebook/Dockerfile
Outdated
|
|
||
| # clean | ||
| RUN apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
clean has to always be in the same RUN line as install, otherwise it doesn't help.
php-notebook/Dockerfile
Outdated
| wget https://download.opensuse.org/repositories/network:/messaging:/zeromq:/release-stable/Debian_9.0/Release.key -O- | sudo apt-key add && \ | ||
| apt-get update && \ | ||
| apt-get install -y --no-install-recommends \ | ||
| libzmq3-dev |
There was a problem hiding this comment.
It would be best if all of the apt commands could be a single RUN, including clean.
|
@to-masz thanks for the contribution. Can you help out maintaining here? |
|
Looks okay, thanks! @parente what do we need to do with respect to build hooks, etc. to get a new stack building? |
|
@minrk If you want to sanity-check the steps I wrote for setting up Docker Cloud, they're in https://github.com/jupyter/docker-stacks#maintainer-workflow under the "When there's a new stack definition, do the following before merging the PR with the new stack:" section. If you're hacking on other things, I can get to them later. |
|
|
||
| ## What it Gives You | ||
|
|
||
| * Minimally-functional Jupyter Notebook 5.0.x (e.g., no pandoc for document conversion) |
There was a problem hiding this comment.
The Dockerfile is based on jupyter/minimal-notebook which does have pandoc. See README here: https://github.com/jupyter/docker-stacks/tree/master/minimal-notebook
Did you mean to base it on base-notebook?
| USER root | ||
|
|
||
| RUN echo "deb http://download.opensuse.org/repositories/network:/messaging:/zeromq:/release-stable/Debian_9.0/ ./" >> /etc/apt/sources.list && \ | ||
| wget https://download.opensuse.org/repositories/network:/messaging:/zeromq:/release-stable/Debian_9.0/Release.key -O- | sudo apt-key add |
There was a problem hiding this comment.
Does it make sense to be pulling packages from opensuse for debian when the images are based on ubuntu?
| RUN cd /tmp && \ | ||
| wget https://litipk.github.io/Jupyter-PHP-Installer/dist/jupyter-php-installer.phar && \ | ||
| chmod +x jupyter-php-installer.phar && \ | ||
| ./jupyter-php-installer.phar install -vv |
There was a problem hiding this comment.
Out of curiosity, to what directory does this install the kernel and the kernel.json kernelspec?
parente
added
the
status:Need Info
|
Hi @to-masz. We'd like to start encouraging the growth of community-maintained stacks in other repositories as an alternative to continually expanding the set and scope of images maintained here. I think this image would make a fine addition to the ecosystem we're trying to cultivate, and would love it if you were to be one of the first to follow the new community stacks documentation to set up a project. If you do decide to give it a shot, please feel free to submit a PR updating the documentation site with a link to the git repository. (The community stacks documentation includes this suggestion along with steps to do it.) |
parente
added
tag:Community Stack
|
I'm going to close this PR as inactive. If someone picks up the torch and creates a community maintained PHP image, please submit a PR to linking to it from the documentation. |
PHP stack based on official Base Jupyter Notebook Stack
It comes with PHP 7.0 and Jupyter-PHP kernel