-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datascience-python-r-notebook #1569
Add datascience-python-r-notebook #1569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also https://github.com/jupyter/docker-stacks/blob/master/docs/using/selecting.md#image-relationships has to be upgraded.
To be honest, I don't think adding new image is what we should do.
I do understand, that you want the image to work under arm, but the better approach would be to fix our build system to use native arm runners.
It's difficult, but it's worth it.
taggers=[RVersionTagger, JuliaVersionTagger], | ||
manifests=[RPackagesManifest, JuliaPackagesManifest], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taggers and manifests are inherited, so you only need to add julia here.
[![docker pulls](https://img.shields.io/docker/pulls/jupyter/datascience-notebook.svg)](https://hub.docker.com/r/jupyter/datascience-notebook/) | ||
[![docker stars](https://img.shields.io/docker/stars/jupyter/datascience-notebook.svg)](https://hub.docker.com/r/jupyter/datascience-notebook/) | ||
[![image size](https://img.shields.io/docker/image-size/jupyter/datascience-notebook/latest)](https://hub.docker.com/r/jupyter/datascience-notebook/ "jupyter/datascience-notebook image size") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links seem to be wrong.
- "datascience-python-r-notebook/**" | ||
- "datascience-notebook/**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it sorted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm strongly opposed to adding another image to this repo. If we should do that, I think we should first have clear guidelines on when and why we do decide to add another images. My opposition stems from a care of this projects long term maintainability, not that the addition has no value for an end user.
I've seen several open source projects run into trouble for accepting more and more variations of something when there are infinite amounts of variations possible. I think they all need to say stop after a while as it becomes unsustainable to keep adding new parts.
@romainx @mathbunnyru what do you think?
@consideRatio and @mathbunnyru agree for the past years the answer for new images--even if they make sense and are interesting--was
So I think we are in this case here and moreover this image is more a workaround to fix issues with ARM and Julia than a new features based image. |
Thank you for your reviews! |
@massongit You may be interested in https://gitlab.b-data.ch/jupyterlab/r/docker-stack, which combines https://github.com/rocker-org/rocker-versioned with https://github.com/jupyter/docker-stacks (± minimal-notebook) including code-server and further customisations. See also https://demo.jupyter.b-data.ch for a minimal deployment (CPU: 2 cores, RAM: 4 GB) based on https://gitlab.com/b-data/docker/deployments/jupyter serving either registry.gitlab.b-data.ch/jupyterlab/r/verse:latest-root or registry.gitlab.b-data.ch/jupyterlab/julia/ver:latest-root. Both JupyterLab images have stock Python (currently v3.9.2) installed and focus on Julia and R, respectively. Thus, apart from |
fix #1551
I add
datascience-python-r-notebook
, which is a multi-architecture stack based onjupyter/datascience-notebook
without Julia.If it add, users who do not use Julia will be able to use
jupyter/datascience-notebook
on M1 Mac and latest Docker Desktop for Mac.