Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setup script to install Julia + IJulia #1927

Merged
merged 16 commits into from
Jun 29, 2023

Conversation

yuvipanda
Copy link
Contributor

Describe your changes

Based on #1926 (comment),
move Julia installation to a common script.

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@yuvipanda yuvipanda force-pushed the install-julia-bash branch from c1fc2a8 to 620ea18 Compare June 28, 2023 18:59
@yuvipanda
Copy link
Contributor Author

@mathbunnyru So I added the script, but am not sure how exactly to get it into both the julia and datascience notebooks. I've proposed one way here, stolen from @cboettig's ideas in rocker (https://github.com/rocker-org/rocker-versioned2/blob/965e5a8dbb493dfced6f1463ae7f1f5cd53987e5/dockerfiles/r-ver_4.3.1.Dockerfile#L19). This also allows easier extension downstream - for example, if someone wants to add julia to a spark image, for example. They can just extend and call install-julia.bash. LMK if this sounds good to you?

@mathbunnyru
Copy link
Member

@mathbunnyru So I added the script, but am not sure how exactly to get it into both the julia and datascience notebooks. I've proposed one way here, stolen from @cboettig's ideas in rocker (https://github.com/rocker-org/rocker-versioned2/blob/965e5a8dbb493dfced6f1463ae7f1f5cd53987e5/dockerfiles/r-ver_4.3.1.Dockerfile#L19). This also allows easier extension downstream - for example, if someone wants to add julia to a spark image, for example. They can just extend and call install-julia.bash. LMK if this sounds good to you?

I totally agree with this approach and I actually proposed it as well in my comment in a previous PR 😃

@yuvipanda yuvipanda marked this pull request as ready for review June 28, 2023 19:18
@yuvipanda
Copy link
Contributor Author

@mathbunnyru great! waiting for tests to complete, but what do you think of this? :)

@yuvipanda yuvipanda changed the title Install julia bash Add a setup script to install Julia + IJulia Jun 28, 2023
Copy link
Member

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice.
I would like to propose to move the Julia version handling to the bash script as well (and remove it from both Dockerfiles)
Something like - if environment variable is set, use it. If not, use the default version defined in the bash script.

minimal-notebook/setup-scripts/setup-ijulia.bash Outdated Show resolved Hide resolved
@yuvipanda
Copy link
Contributor Author

@mathbunnyru done!

Copy link
Member

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good now.
Just a few minor things to cleanup and we can merge this :)

datascience-notebook/Dockerfile Outdated Show resolved Hide resolved
datascience-notebook/Dockerfile Outdated Show resolved Hide resolved
julia-notebook/Dockerfile Outdated Show resolved Hide resolved
minimal-notebook/Dockerfile Outdated Show resolved Hide resolved
minimal-notebook/setup-scripts/setup-ijulia.bash Outdated Show resolved Hide resolved
yuvipanda and others added 4 commits June 28, 2023 13:10
Put it in the bash script instead
Cleaner than putting a whole directory under /usr/local/bin
@yuvipanda
Copy link
Contributor Author

hmm, it looks like you need to explicitly approve the GitHub run, @mathbunnyru! Not sure why that happened suddenly.

@mathbunnyru
Copy link
Member

The last commit was from the pre-commit.ci[bot] (run pre-commit install in the folder with this repo, your life will be easier 🙂 ) .
And we use self-hosted runners here, they are not isolated, so I only allow actions to be run either by members of the organization or I have to run them explicitly, when there is an outside contributor.

@yuvipanda
Copy link
Contributor Author

Yeah, been relying on pre-commit.ci because I fucked up my local node install bad enough that prettier won't run anymore and am too lazy to fix it :D

Oooh, TIL this uses self hosted runners! Thank you :)

@yuvipanda
Copy link
Contributor Author

Hooray, tests pass!

@mathbunnyru mathbunnyru merged commit b07eb7a into jupyter:main Jun 29, 2023
@yuvipanda
Copy link
Contributor Author

Yay, thank you @mathbunnyru!

kentwait pushed a commit to kentwait/docker-stacks that referenced this pull request Aug 3, 2023
tomyun added a commit to cropbox/Cropbox.jl that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants