-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setup script to install Julia + IJulia #1927
Conversation
c1fc2a8
to
620ea18
Compare
@mathbunnyru So I added the script, but am not sure how exactly to get it into both the julia and datascience notebooks. I've proposed one way here, stolen from @cboettig's ideas in rocker (https://github.com/rocker-org/rocker-versioned2/blob/965e5a8dbb493dfced6f1463ae7f1f5cd53987e5/dockerfiles/r-ver_4.3.1.Dockerfile#L19). This also allows easier extension downstream - for example, if someone wants to add julia to a spark image, for example. They can just extend and call |
I totally agree with this approach and I actually proposed it as well in my comment in a previous PR 😃 |
@mathbunnyru great! waiting for tests to complete, but what do you think of this? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice.
I would like to propose to move the Julia version handling to the bash script as well (and remove it from both Dockerfiles)
Something like - if environment variable is set, use it. If not, use the default version defined in the bash script.
@mathbunnyru done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good now.
Just a few minor things to cleanup and we can merge this :)
Put it in the bash script instead
Cleaner than putting a whole directory under /usr/local/bin
for more information, see https://pre-commit.ci
hmm, it looks like you need to explicitly approve the GitHub run, @mathbunnyru! Not sure why that happened suddenly. |
The last commit was from the |
Yeah, been relying on pre-commit.ci because I fucked up my local node install bad enough that prettier won't run anymore and am too lazy to fix it :D Oooh, TIL this uses self hosted runners! Thank you :) |
Hooray, tests pass! |
Yay, thank you @mathbunnyru! |
Describe your changes
Based on #1926 (comment),
move Julia installation to a common script.
Issue ticket if applicable
Checklist (especially for first-time contributors)