Whitespace #11
Closed
Whitespace #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UIEditor : Fix Python 3 compatibility
…tyleFix SpreadsheetUI : Update scroller styling for Qt5.12
Make ValuePlug::dirtyCount Public
Prep for release of 0.59.0.0
This dates back to when Attributes derived from SceneElementProcessor, which it no longer does.
This allows it to express the full range of possible of attributes, including shader networks.
We were inconsistent with the standardised logic established whilst working on the `SceneViewInspector`. We picked EditScopes in preference over any applicable nodes inside the scope. This could result in unnecessary `TranformEdits` being made, even if the the target location's source node was inside the scope, or there was an existing Transform node editing that location.
Provides more detail, and matches the language used in the `SceneViewInspector`.
…dits Though the tool correctly handled readOnly state for for existing plugs, it was still possible to inadvertently insert rows into `TransformEdits`, even if the `edits` plug was locked (inherited or otherwise).
…ttributes Attributes : Change type of `extraAttributes` to CompoundObjectPlug
…ctionTweaks TransformTool : Use standardised selection logic
- M33fVectorDataPlug is a new plug - M33fPlug already existed but was not included in PlugAlgo::extractDataFromPlug
We noticed the disparity in GafferHQ#4045 where dragMove would have a different origin to mouseMove.
…ixes Widget : Ensure correct origin is used for ButtonEvent position
Fixes some cursor offsets introduced since we fixed the coordinates reported in `GafferUI.ButtonEvent` in GafferHQ#4053.
GafferUI : Fix use of Gaffer Widget mouse event positions
…NoCon Encapsulation in Instancer
This was made redundant by ad299e2.
SceneInspector/GraphEditor improvements (backport)
The overlapping-but-mismatched functionality between `parallelTraverse()` and `parallelProcessLocations()` is a mess, and longer term I think we should be adding filtering to `parallelProcessLocations()` and deprecating `parallelTraverse()`. But doing that without breaking changes is a little bit thorny, so this will suffice for now.
FilterResults : Add `root` plug
CollectScenesUI : Add ScenePathPlugValueWidget to `sourceRoot`
- Prevent accidental cancellation via <kbd>Enter</kbd>. - Allow cancellation by <kbd>Esc</kbd>.
…eaks BackgroundTaskDialogue : Improve cancellation interactions
…dings SceneAlgo : Bind `matchingPathsHash()`
SceneAlgo : Fix `matchingPathsHash()` bug handling root matches
When this code was first written, we weren't using `__updateLazily()` to defer updates until the UI was visible again, so the shortcut for invisible UIs may have been warranted. But now we do defer things nicely, and we definitely don't want to lose updates for things that happened while we weren't visible.
PlugLayout : Fix activity/summary updates
But disable the widget for nodes which require sequence exectution.
Dispatcher : Fix batchSize when driven by a context variable
…roup Instancer : Add missing task_group_contexts when launching threads
- Remove spaces used for indentation - Remove trailing whitespace - Remove extra blank lines at end of files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed
Related issues
Dependencies
Breaking changes
Checklist