Instancer : Add missing task_group_contexts when launching threads #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnhaddon
requested changes
Apr 8, 2021
| @@ -1356,6 +1356,8 @@ void Instancer::hash( const Gaffer::ValuePlug *output, const Gaffer::Context *co | |||
|
|
|||
| IECore::ConstCompoundDataPtr prototypeChildNames = this->prototypeChildNames( parentPath, context ); | |||
|
|
|||
| tbb::task_group_context taskGroupContext( tbb::task_group_context::isolated ); | |||
There was a problem hiding this comment.
This needs to be passed as an argument to parallel_for.
| @@ -1637,6 +1639,8 @@ void Instancer::compute( Gaffer::ValuePlug *output, const Gaffer::Context *conte | |||
|
|
|||
| vector<InternedString> branchPath( { namePlug()->getValue() } ); | |||
|
|
|||
| tbb::task_group_context taskGroupContext( tbb::task_group_context::isolated ); | |||
There was a problem hiding this comment.
This needs to be passed as an argument to parallel_for.
danieldresser-ie
force-pushed
the
instancerTaskGroup
branch
from
2390adc
to
08ae893
Compare
|
Apologies for the sloppy PR, fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it can be pretty tricky to demonstrate what situations this actually goes wrong in, so for the moment I've just added the obvious missing task_group_contexts - is this good enough as a PR?