FilterResults : Add root plug
#4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I do kind of wonder about generalization ... what if you had a list of paths and wanted to search under all of them? But I guess that would be more of a job for a filter intersection node. This code looks like quite a clean and simple extension |
|
Yeah, I wondered about generalisation too, but came to the same conclusion as you. I think there's merit in making the simple case very simple, and then falling back to "use a more complex filter" for the complex case. Part of the reason I liked this though was that it made the prototype I'm making at the moment trivial to construct. I'm not sure the final thing is going to need it though, so I'll leave this open a little while to see if anyone voices an alternative opinion. |
The overlapping-but-mismatched functionality between `parallelTraverse()` and `parallelProcessLocations()` is a mess, and longer term I think we should be adding filtering to `parallelProcessLocations()` and deprecating `parallelTraverse()`. But doing that without breaking changes is a little bit thorny, so this will suffice for now.
johnhaddon
force-pushed
the
filterResultsRoot
branch
from
9c0cce0
to
63a3cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isolates the search to
rootand its descendants. It could be used for optimisation, but I'm actually aiming to use it in conjunction with the newParent.parentVariablefeature from #4178 to faciliate some new patterns for processing subtrees and placing the result at the subtree root.