SpreadsheetUI : Support drop of values/plugs on to cells #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themissingcow
force-pushed
the
spreadsheetPlugDragDrop
branch
from
a0c702d
to
75cc4a8
Compare
themissingcow
changed the title
themissingcow
force-pushed
the
spreadsheetPlugDragDrop
branch
from
3df33fc
to
e71feac
Compare
themissingcow
added
the
pr-hold
themissingcow
pushed a commit
to themissingcow/gaffer
that referenced
this pull request
Dec 7, 2020
We noticed the disparity in GafferHQ#4045 where dragMove would have a different origin to mouseMove.
themissingcow
pushed a commit
to themissingcow/gaffer
that referenced
this pull request
Dec 7, 2020
We noticed the disparity in GafferHQ#4045 where dragMove would have a different origin to mouseMove.
themissingcow
pushed a commit
to themissingcow/gaffer
that referenced
this pull request
Dec 7, 2020
We noticed the disparity in GafferHQ#4045 where dragMove would have a different origin to mouseMove.
themissingcow
pushed a commit
to themissingcow/gaffer
that referenced
this pull request
Dec 9, 2020
We noticed the disparity in GafferHQ#4045 where dragMove would have a different origin to mouseMove.
themissingcow
force-pushed
the
spreadsheetPlugDragDrop
branch
from
e71feac
to
405623b
Compare
themissingcow
changed the base branch from
0.58_maintenance
to
0.59_maintenance
themissingcow
removed
the
pr-hold
themissingcow
force-pushed
the
spreadsheetPlugDragDrop
branch
from
405623b
to
d5baad0
Compare
johnhaddon
requested changes
Dec 10, 2020
|
Thanks for the 🦅 👁️ as ever John, hopefully those are all addressed. Going to go give it a poke. |
themissingcow
added
the
pr-hold
|
Hold till #4063 is merged |
johnhaddon
approved these changes
Dec 15, 2020
|
Thanks Tom, LGTM. Could you do the rejig now that #4063 is merged, and squash the fixups down too? |
johnhaddon
removed
the
pr-hold
themissingcow
force-pushed
the
spreadsheetPlugDragDrop
branch
from
83149ee
to
ef01225
Compare
Thanks @johnhaddon, quashed and rebased. |
There was some debate as to how drag/drop should interact with the sheet's selection. This option simply replaces the selection as appropriate target cells are hovered. This mimics the existing `setHighlighted` behaviours of other UI elements. An alternative suggestion was to only apply the drop to the current selection. This would simplify setting the input to multiple cells at once, but make the case of setting a single cell harder as it would need to be selected first. We can always revisit this over time as it is used more in practice.
Make use of the existing paste mechanism. Long term this should probably be better aligned with `PlugValueWidget.__drop`.
Allows strings to be pasted into vector data plugs, and single element vectors to be pasteed into string plugs.
johnhaddon
force-pushed
the
spreadsheetPlugDragDrop
branch
from
ef01225
to
4448746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some debate as to how drag/drop should interact with the sheet's selection. This option simply replaces the selection as appropriate target cells are hovered. This mimics the existing
setHighlightedbehaviours of other UI elements.An alternative suggestion was to only apply the drop to the current selection. This would simplify setting the input to multiple cells at once, but make the case of setting a single cell harder as it would need to be selected first.
We can always revisit this over time as
it is used more in practice.