[JENKINS-45693] Calling TaskListenerDecorator #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for getLogFile().
…y encompassing all of the functionality of jenkinsci#21.
Also using jitpack and linking to jenkinsci/maven-hpi-plugin#46 & jenkinsci/workflow-api-plugin#17 & jenkinsci/workflow-support-plugin#15.
Unfortunately it is also necessary to <exclude> the official dependency GAs to avoid duplication, which seems like a fundamental limitation of jitpack.io as applied to Maven.
This was referenced Sep 5, 2018
…tep logs, even for steps running across the upgrade. In this example, log is complete and the raw log is identical to what it would have been without an upgrade; the first echo step and the sleep step use LogActionImpl and have complete *.log files; the second echo step uses LogStorageAction and log-index records its range.
… should be idempotent.
svanoort
approved these changes
Sep 28, 2018
dwnusbaum
approved these changes
Sep 28, 2018
|
Note: approval contingent on fixes to the upstream PR(s) and their approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-45693, more or less.
Subsumes #27. Downstream of jenkinsci/workflow-api-plugin#76 & jenkinsci/workflow-support-plugin#72.
Originally in JENKINS-30777, @kohsuke attempted in jenkinsci/jenkins#1833 to make
ConsoleLogFilters registered globally as@Extensions applicable toWorkflowRun. He only defined a new method signature, though, and did not call it fromworkflow-job, so on its own this did nothing. In fact among the known implementations few are actual extensions:Serializable. But as I noted there, the implementation will not in fact work under JEP-210.HumioConsoleLogListener, whatever that is, could not work under JEP-210 for the same reason, even if it wereSerializable, which it is not.ConsoleLogFiltercould not actually work for interesting use cases: as noted inTaskListenerDecoratorJavadoc, that API would make it physically impossible to define a global filter which was both compatible with JEP-210 remote logging and took into account which build’s output it was decorating, because the injection of theRuncontext occurs “at the last minute” and this context is not remotable. So rather than applyingConsoleLogFilter.all, this set of PRs uses a new API designed with these use cases in mind. As the examples above show, this approach is more backwards compatible, and there are no existing extensions which would have benefitted anyway.ConsoleLogFiltermay however continue to be used contextually, which plenty of plugins do (withCredentialsis a good example).#66 and jenkinsci/workflow-support-plugin#57 both attempted to address something like JENKINS-45693. This PR supersedes both.