Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pipeline output decoration #66

Closed
wants to merge 1 commit into from
Closed

Allow pipeline output decoration #66

wants to merge 1 commit into from

Conversation

lucamilanesio
Copy link
Member

Allow other plugins to provide a decorator to filter
the output of a Jenkins Pipeline.

Allow other plugins to provide a decorator to filter
the output of a Jenkins Pipeline.
@svanoort
Copy link
Member

Seems reasonable to me @lucamilanesio but do you have an implementation taking advantage of the new API to go along with it? Generally we like to have at least one consumer for net-new APIs.

@lucamilanesio
Copy link
Member Author

Yes, will push shorty a plug that extends the current logstash plugin for streaming the pipeline output, will showcase as well on Tuesday at JenkinsWorld

@svanoort
Copy link
Member

Okay, this is probably something that will be of special interest to @jglick since he's done work specifically related to external logging.

@lucamilanesio
Copy link
Member Author

@jglick any feedback? The logger decoration is very useful with the current master and with the additional refactoring that you are currently doing on your PR.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to use the existing SPI. JENKINS-45693 And this would need test coverage.

@jglick
Copy link
Member

jglick commented Sep 6, 2018

Anyway should be obsoleted by #105.

@bitwiseman
Copy link
Contributor

@lucamilanesio Would you agree this obsolete? Should this PR be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants