use modern api in ConsoleLogFilter to allow for pipeline jobs to be filtered globally #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled globally it should work with all types of Jobs, also pipelines once JENKINS-45693 is fixed.
| @@ -69,7 +43,9 @@ | |||
| * @author Jason Antman jason@jasonantman.com | |||
| */ | |||
| @Extension | |||
| public class MaskPasswordsConsoleLogFilter extends ConsoleLogFilter { | |||
| public class MaskPasswordsConsoleLogFilter extends ConsoleLogFilter implements Serializable { | |||
There was a problem hiding this comment.
does it really need to be serializable?
There was a problem hiding this comment.
There was a problem hiding this comment.
It is not going to work, since you will be calling MaskPasswordsConfig.getInstance() from the agent JVM and this will at best return junk.
To make this actually function, you would need to create a writeReplace method which captures passwords and regexes in a nontransient instance field, or something similar.
|
Agreed |
|
Hi, I'am really interesting by this PR, when it will be released ? Thanks you |
|
Thanks for the ping, releasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled globally it should work with all types of Jobs, also pipelines. Depends on JENKINS-45693 or that JENKINS-38381 implements this.