More fixes to mojos that assumed that plugin artifacts used a short name identical to the artifactId #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame identical to the artifactId.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
added a commit
to jglick/workflow-job-plugin
that referenced
this pull request
Dec 21, 2016
Unfortunately it is also necessary to <exclude> the official dependency GAs to avoid duplication, which seems like a fundamental limitation of jitpack.io as applied to Maven.
jglick
commented
Dec 21, 2016
| File dst = new File(testDir, a.getArtifactId() + ".hpi"); | ||
| String artifactId = a.getActualArtifactId(); | ||
| if (artifactId == null) { | ||
| getLog().debug("Skipping " + artifactId + " with classifier " + a.getClassifier()); |
jglick
commented
Dec 21, 2016
| continue; | ||
| } | ||
|
|
||
| getLog().debug("Copying " + artifactId + " as a test dependency"); |
There was a problem hiding this comment.
Would also be useful to fail the build is an attempt is made to copy the same plugin twice. I think this could be reproduced in the test by, e.g., adding a test-scoped dependency on mercurial, which then pulls in a transitive dependency on some earlier version of scm-api, without excludeing it as per jitpack/jitpack.io#1029.
andresrc
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #46.
@reviewbybees