Enable using @LocalData for JUnit5 tests
#900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This was referenced Jan 21, 2025
Vlatombe
added a commit
to Vlatombe/jenkins-test-harness
that referenced
this pull request
Jan 23, 2025
By switching to `getDeclaredMethod` in jenkinsci#900, this broke this use case that is currently exercised in email-ext plugin (`ScriptContentSecureTest>ScriptContentTest#testTemplateShouldBeLoadedFromTheClosestExistingFolderConfigInTheHierarchyUpToGlobalConfig`)
6 tasks
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there seems to be no way to make JUnit5 tests annotated with
@LocalDatato resolve the local data in a convenient way.This PR adds support by adapting the recipe resolution in
org.jvnet.hudson.test.junit.jupiter.JUnit5JenkinsRule#recipeas well as the test method resolution inorg.jvnet.hudson.test.recipes.LocalData.RuleRunnerImpl#setup.This change enables more tests to migrate to JUnit5
Testing done
Added 4 new tests that demonstrate the correct resolution of
@LocalDatain JUnit5 tests,Submitter checklist