Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tests to JUnit5 #232

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Migrate tests to JUnit5 #232

merged 2 commits into from
Jan 28, 2025

Conversation

strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Jan 22, 2025 •
edited
Loading

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations
  • Migrate assertions
  • Remove public visibility of test classes and methods
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd
Migrate tests to JUnit5
8ecb37b 
* Migrate annotations
* Migrate assertions
* Remove public visibility of test classes and methods
@TobiX TobiX self-assigned this Jan 22, 2025
@TobiX TobiX added chore Maintenance java Pull requests that update Java code labels Jan 22, 2025
@strangelookingnerd strangelookingnerd marked this pull request as ready for review January 27, 2025 19:49
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner January 27, 2025 19:49
@TobiX TobiX merged commit fde72d4 into jenkinsci:main Jan 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiX TobiX TobiX approved these changes

Assignees

@TobiX TobiX

Labels
chore Maintenance java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strangelookingnerd @TobiX