Migrate tests to JUnit5 #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed a 30 second duration increase for test execution phase: https://ci.jenkins.io/job/Plugins/job/jira-plugin/job/PR-634/5/pipeline-console/log?nodeId=51 3m3s https://ci.jenkins.io/job/Plugins/job/jira-plugin/job/master/451/pipeline-console/log?nodeId=112 2m27s Do you think it might be related to the changes in any way? |
* Use JUnit5 annotations and imports * Cleanup assertions * Remove public visibility from test classes and methods
* Use JUnit5 annotations and imports * Cleanup assertions * Remove public visibility from test classes and methods
strangelookingnerd
force-pushed
the
migrate_to_junit5
branch
from
f6b411a to
bffdb1d
Compare
|
I took a closer look at it and compared the execution times of tests before and after my changes on my local machine.
In my runs, the JUnit5 tests were faster compared to JUnit4. There is little reliable data available on comparison of performance between these two frameworks but looking at the numbers I'd say they are equal. |
|
Great comparison, thanks a lot for spending additional time on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewd.
If there are any questions, please do not hesitate to ping me.