Migrate tests to JUnit5 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangelookingnerd
force-pushed
the
migrate_to_junit5
branch
from
69917af to
778d32a
Compare
* Migrate annotations and imports * Migrate assertions * Remove public visibility for test classes and methods * Minor clean up
strangelookingnerd
force-pushed
the
migrate_to_junit5
branch
from
778d32a to
7d23a22
Compare
6 tasks
mawinter69
requested changes
Mar 7, 2025
| @@ -114,13 +118,13 @@ private static void testCycle(String macroName, Integer macroId, String[] parame | |||
| } | |||
|
|
|||
| private static void assertEquals(Macro expected, Macro actual) { | |||
| Assert.assertEquals("Wrong name", expected.getName(), expected.getName()); | |||
| Assert.assertEquals("Wrong index", expected.getIndex(), expected.getIndex()); | |||
| Assertions.assertEquals(expected.getName(), actual.getName(), "Wrong name"); | |||
There was a problem hiding this comment.
Can we statically import the assertEquals and use it like that in this file. Then we're in sync with all other files how to import the Assertions
There was a problem hiding this comment.
We can't since it would ambiguous with the surrounding method MacroTest#assertEquals(Macro, Macro)
mawinter69
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate all tests to JUnit5. Changes include:
Some tests fail due to jenkinsci/jenkins-test-harness#901 which will likely be fixed in plugin-pom 5.7. I'll update the PR once it is available.Some tests fail due to jenkinsci/configuration-as-code-plugin#2637 which will likely be fixed in an upcoming release of
configuration-as-code-pluginvia bom. I'll update the PR once it is available.I am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.
If there are any questions, please do not hesitate to ping me.