Avoid data-tables, echarts, and prism upper bounds error #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@basil described it in jenkinsci#2680 (comment) > analysis-pom is (incorrectly) pulling in a version of ArchUnit with > a requireUpperBounds error, which analysis-pom has (also > incorrectly) downgraded from an error to a warning.... Since PCT > will automatically resolve requireUpperBoundDeps errors by choosing > the newer version, and since the newer version is not ABI-compatible > with the older version, the issue occurs. This workaround should be removed when analysis-pom has been updated to fix the requireUpperBoundDeps error and make requireUpperBoundDeps an error instead of a warning.
6 tasks
timja
approved these changes
Nov 23, 2023
MarkEWaite
deleted the
workaround-upperbounds-error-in-echarts-and-more
branch
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Dec 5, 2023
…kinsci#2682)" Resolved in analysis-pom 6.17.0 that is included in: * jenkinsci/data-tables-api-plugin#411 * jenkinsci/prism-api-plugin#130 * jenkinsci/echarts-api-plugin#317 * jenkinsci/bootstrap5-api-plugin#255 This reverts commit 92e1dbc.
renovate bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…)" Resolved in analysis-pom 6.17.0 that is included in: * jenkinsci/data-tables-api-plugin#411 * jenkinsci/prism-api-plugin#130 * jenkinsci/echarts-api-plugin#317 * jenkinsci/bootstrap5-api-plugin#255 This reverts commit 92e1dbc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid data-tables, echarts, and prism upper bounds error
@basil described it in #2680 (comment)
This workaround should be removed when analysis-pom has been updated to fix the requireUpperBoundDeps error and make requireUpperBoundDeps an error instead of a warning.
Testing done
Confirmed that
PLUGINS=echarts-api TEST=InjectedTest bash local-test.shpasses after this change and fails before this change.Submitter checklist