Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid data-tables, echarts, and prism upper bounds error #2682

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Avoid data-tables, echarts, and prism upper bounds error #2682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4beca99
Avoid data-tables, echarts, and prism upper bounds error
MarkEWaite Nov 22, 2023
6e4b79b
Merge branch 'master' into workaround-upperbounds-error-in-echarts-an…
MarkEWaite Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pct.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,28 @@ if ! [[ $PLUGINS =~ blueocean || $PLUGINS =~ pipeline-maven ]]; then
#
PCT_D_ARGS+='-DforkCount=.75C '
fi
if [[ $PLUGINS =~ data-tables-api || $PLUGINS =~ echarts-api || $PLUGINS =~ prism-api ]]; then
#
# These plugins use a version of ArchUnit which triggers a
# requireUpperBoundDeps error with JUnit 5:
#
# +-io.jenkins.plugins:data-tables-api:1.13.8-1
# +-com.tngtech.archunit:archunit-junit5:1.2.0 [test]
# +-com.tngtech.archunit:archunit-junit5-engine:1.2.0 [test]
# +-com.tngtech.archunit:archunit-junit5-engine-api:1.2.0 [test]
# +-org.junit.platform:junit-platform-engine:1.10.0 [test] (managed)
# <-- org.junit.platform:junit-platform-engine:1.10.1 [test]
#
# Since PCT will automatically resolve requireUpperBoundDeps errors by
# choosing the newer version, and since the newer version is not
# ABI-compatible with the older version, exclude this package from PCT's
# requireUpperBoundDeps resolution.
#
# TODO: When these plugins are fixed to not trigger a requireUpperBoundDeps
# error, this code should be removed.
#
PCT_D_ARGS+='-DupperBoundsExcludes=org.junit.platform:junit-platform-commons '
fi

exec java \
-jar target/pct.jar \
Expand Down