Skip to content

Commit

Permalink
Revert "Avoid data-tables, echarts, and prism upper bounds error (#2682
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkEWaite authored and renovate[bot] committed Dec 5, 2023
1 parent 3dc4578 commit 888cff4
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions pct.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,6 @@ if ! [[ $PLUGINS =~ blueocean || $PLUGINS =~ pipeline-maven ]]; then
#
PCT_D_ARGS+='-DforkCount=.75C '
fi
if [[ $PLUGINS =~ data-tables-api || $PLUGINS =~ echarts-api || $PLUGINS =~ prism-api ]]; then
#
# These plugins use a version of ArchUnit which triggers a
# requireUpperBoundDeps error with JUnit 5:
#
# +-io.jenkins.plugins:data-tables-api:1.13.8-1
# +-com.tngtech.archunit:archunit-junit5:1.2.0 [test]
# +-com.tngtech.archunit:archunit-junit5-engine:1.2.0 [test]
# +-com.tngtech.archunit:archunit-junit5-engine-api:1.2.0 [test]
# +-org.junit.platform:junit-platform-engine:1.10.0 [test] (managed)
# <-- org.junit.platform:junit-platform-engine:1.10.1 [test]
#
# Since PCT will automatically resolve requireUpperBoundDeps errors by
# choosing the newer version, and since the newer version is not
# ABI-compatible with the older version, exclude this package from PCT's
# requireUpperBoundDeps resolution.
#
# TODO: When these plugins are fixed to not trigger a requireUpperBoundDeps
# error, this code should be removed.
#
PCT_D_ARGS+='-DupperBoundsExcludes=org.junit.platform:junit-platform-commons '
fi

exec java \
-jar target/pct.jar \
Expand Down

0 comments on commit 888cff4

Please sign in to comment.