Added artist list concatenation for albums that have over 10 artists

[alfred-delacosta]

Changes
Added condition to determine if the artist count of music is over 10 and if so, the displaying text will be changed to only display the first 10 artists and will have "and X other artists." concatenated to the end of it.

Issues
Fixes #4228

[alfred-delacosta]

Screenshot of fix:

[oddstr13]

Please review https://jellyfin.org/docs/general/contributing/development#pull-request-guidelines

Pull-request titles will eventually end up in the release change-log, so make sure it's short and descriptive 😺

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.5% Duplication

[thornbill]

Code looks good now. It would be nice if someone could confirm the functionality works as expected... I don't seem to have any albums available that have enough artists to test. 😅

[oddstr13]

Before

After

TV mode

Mobile

Experimental

---

The optimal number of entries seem to be highly dependent on resolution, display mode and potentially theme.
There does not seem to be a way to see all album artists with this PR?
From an UX perspective, I sort of expected the "and # other artists" to be interactive in some way, to actually be able to see them.

[thornbill]

This should fix the extra slash showing up before the "and other artists" text.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.3% Duplication

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

[twihno]

I don't think this PR solves the issue. It's a good feature to have if you do have more than 10 album artists but not if it's a compilation.
I wrote a quick overview of my interpretation in the linked issue. I don't want to duplicate the comment, so here's the link: #4228

[felix920506]

I just tested this PR using the version deployed to Cloudflare pages and there are 2 items that would need to be addressed.

1. There should be a space between the last artist and "and xxx other artists"
   

2. This falls apart when the browser window is resized to something narrow. I think this s an acceptable compromise for this PR as it is already a significant improvement over the current situation. This should however have a new issue opened for it.
   

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

[felix920506]

These 2 changes should address my comment above and improve compatibility with RTL languages when doing localization.

This image is with the changes below applied

Changing the order of which the lists of artists appear in the strings

using source string {1} artists and {0}

[1hitsong]

Instead of updating the number of artists shown to a hard-coded value, can we instead just use CSS to limit the displayed artists to 2 lines?

display: -webkit-box;
-webkit-line-clamp: 2;
-webkit-box-orient: vertical;  
overflow: hidden;

[alfred-delacosta]

These 2 changes should address my comment above and improve compatibility with RTL languages when doing localization.

This image is with the changes below applied

Changing the order of which the lists of artists appear in the strings using source string {1} artists and {0}

So the first image shows what it would look like in a LTR language setting and the second image shows would it would look like in a RTL language setting? I just want to confirm that's my understanding of your post and changes.

[thornbill]

So the first image shows what it would look like in a LTR language setting and the second image shows would it would look like in a RTL language setting? I just want to confirm that's my understanding of your post and changes.

Yes that is correct

[alfred-delacosta]

So the first image shows what it would look like in a LTR language setting and the second image shows would it would look like in a RTL language setting? I just want to confirm that's my understanding of your post and changes.

Yes that is correct

Fantastic then I am going to commit those changes.

[alfred-delacosta]

I'm pretty sure I accepted these changes...

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[alfred-delacosta]

I guess I missed these at some point?...

[alfred-delacosta]

@thornbill Any idea as to why I can't get rid of this message on the PR? I already committed the changes and did so a while ago. At least I thought I did.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	1a6a44293605666ff1eca9487605d2d0c71a3830
Status	✅ Deployed!
Preview URL	https://ff166322.jellyfin-web.pages.dev
Type	🔀 Preview