-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If there are quite a few artists in one album they overflow the UI. #4228
Comments
I came over from the Jellyfin sub Reddit, after learning that the best way to help is through OSS contributions. I've been a React dev for the past 4 years and would like to take this issue on |
Feel free to work on this issue. As you might have found out already; not all parts of the web client are rewritten in React. I'm not sure about this specific page (I don't really work on the web client). If you have any questions our developers are most active on Matrix/Discord. |
Hi, just wanted to ask out of curiosity if this issue has been resolved or worked on yet. thanks. |
No... the status of this issue should be updated if anything changes |
This comment was marked as outdated.
This comment was marked as outdated.
I would like to fix this issue. I will be working on it and when I finish I will submit my PR. |
Could someone verify the fix in #4830 is working as expected by testing the Preview URL: #4830 (comment) I can't seem to find an album that has enough artists to trigger this bug in my library. 😅 |
Image from @Xitee1 (jellyfin/jellyfin#10052 (comment)) to show extreme cases |
As I already mentioned in jellyfin/jellyfin#10052, I don't think that concatinating the artists is a good idea. Concatinating the available artists may fix the overflow, but regarding UX you still have another problem:
You don't get to know the artist corresponding to the track and the artists in the header are always sorted alphabetically which also doesn't help in this case. What i proposed in the mentioned issue (jellyfin/jellyfin#10052) was:
That were just the ideas I came up with but I think that shortening the list isn't a good solution to this problem |
I tried investigating further and noticed some interesting behavior: jellyfin/jellyfin#10052 (comment) TLDR: An empty album artist leads to a bad import which messes with the UI. The UI also doesn't know how to handle an empty album artist |
Describe The Bug
When an album i have in my music library has quite a few artists (about 15) they overflow off the UI bar where the album buttons are. (Heart, Shuffle, Mix, Play)
Expected Behavior
I don't expect anything really, besides for it to not overflow lol.
maybe if there are over 10 artists: say something along the lines of "and {} others..." after it says the first 10?
A quick and dirty inspect element job kinda shows what i mean:
Screenshots
System (please complete the following information):
The text was updated successfully, but these errors were encountered: