Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there are quite a few artists in one album they overflow the UI. #4228

Closed
fwuffyboi opened this issue Dec 27, 2022 · 11 comments · Fixed by #4830
Closed

If there are quite a few artists in one album they overflow the UI. #4228

fwuffyboi opened this issue Dec 27, 2022 · 11 comments · Fixed by #4830
Labels
bug Something isn't working confirmed The issue has been verified

Comments

@fwuffyboi
Copy link

Describe The Bug
When an album i have in my music library has quite a few artists (about 15) they overflow off the UI bar where the album buttons are. (Heart, Shuffle, Mix, Play)

Expected Behavior
I don't expect anything really, besides for it to not overflow lol.
maybe if there are over 10 artists: say something along the lines of "and {} others..." after it says the first 10?
A quick and dirty inspect element job kinda shows what i mean:
image

Screenshots
image

System (please complete the following information):

  • Platform: Linux, ChromeOS
  • Browser: Chrome, Firefox
  • Jellyfin Version: 10.8.7
@fwuffyboi fwuffyboi added the bug Something isn't working label Dec 27, 2022
@danditomaso
Copy link

danditomaso commented Jan 31, 2023

I came over from the Jellyfin sub Reddit, after learning that the best way to help is through OSS contributions. I've been a React dev for the past 4 years and would like to take this issue on

@nielsvanvelzen
Copy link
Member

Feel free to work on this issue. As you might have found out already; not all parts of the web client are rewritten in React. I'm not sure about this specific page (I don't really work on the web client). If you have any questions our developers are most active on Matrix/Discord.

@acreiko
Copy link

acreiko commented Mar 21, 2023

Hi, just wanted to ask out of curiosity if this issue has been resolved or worked on yet. thanks.

@thornbill
Copy link
Member

No... the status of this issue should be updated if anything changes

@jellyfin-bot

This comment was marked as outdated.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Jul 20, 2023
@fwuffyboi
Copy link
Author

bump. this still affects me on the latest docker version of jellyfin web.
image

@jellyfin-bot jellyfin-bot removed the stale No activity for an extended length of time label Jul 21, 2023
@thornbill thornbill added the confirmed The issue has been verified label Jul 24, 2023
@alfred-delacosta
Copy link
Contributor

alfred-delacosta commented Oct 3, 2023

I would like to fix this issue. I will be working on it and when I finish I will submit my PR.

@thornbill
Copy link
Member

Could someone verify the fix in #4830 is working as expected by testing the Preview URL: #4830 (comment)

I can't seem to find an album that has enough artists to trigger this bug in my library. 😅

@felix920506
Copy link
Member

Image from @Xitee1 (jellyfin/jellyfin#10052 (comment)) to show extreme cases
圖片

@twihno
Copy link

twihno commented Feb 3, 2024

As I already mentioned in jellyfin/jellyfin#10052, I don't think that concatinating the artists is a good idea.
The problem with these kinds of albums (at least in my opinion) is that they normally are some kind of compilation with no defined album artist. The way e.g. spotify solves this issue is to show "Various artists" (unclickable) as the album artist.

Concatinating the available artists may fix the overflow, but regarding UX you still have another problem:
Jellyfin web doesn't show the artist of the individual tracks if it "matches" with the album artist.
Let's say you have an album with multiple remixes or

bump. this still affects me on the latest docker version of jellyfin web. image

You don't get to know the artist corresponding to the track and the artists in the header are always sorted alphabetically which also doesn't help in this case.

What i proposed in the mentioned issue (jellyfin/jellyfin#10052) was:

What should Jellyfin do?

(My suggestions)

  • Maybe tag these albums (no album artist, multiple artists) as compilations or something like that? Perhaps clients can handle this specific case more easily with this information
  • Show "Various Artists" (best case: translated) as album artist without generating an artist page. Clients should not make this text clickable. Maybe an option would be to leave the album artist field empty (I don't know what the current behavior is) and let the clients handle this case. Hot take: every piece of music/media was created by at least one person. So if no person is credited for the whole unit/album showing "Various Artists" would always be correct because multiple artists worked on it?
    (I think this would be the best and easiest option)
  • Jellyfin-web: Show the individual artist per Track

That were just the ideas I came up with but I think that shortening the list isn't a good solution to this problem

@twihno
Copy link

twihno commented Feb 3, 2024

I tried investigating further and noticed some interesting behavior: jellyfin/jellyfin#10052 (comment)

TLDR: An empty album artist leads to a bad import which messes with the UI. The UI also doesn't know how to handle an empty album artist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants