Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with displaying very long artist names #5015

Closed
wants to merge 1 commit into from

Conversation

runbing
Copy link

@runbing runbing commented Nov 26, 2023

The artist name field gets messy when I add a music album with a really long artist name.

Changes

I tweaked the desktop layout's CSS to show the artist's name as the item name, cutting off the lengthy text with an ellipsis.

Before:

before

After:

after

Issues

None.

@runbing runbing requested a review from a team as a code owner November 26, 2023 18:25
Copy link

sonarcloud bot commented Nov 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill added the ui & ux This PR or issue mainly concerns UI & UX label Feb 20, 2024
@1hitsong
Copy link
Member

Same root issue is addressed here as #4830

Same as I said there, I like the CSS fix over updating code to a hard-coded value. My 1 suggestion was to allow 2 rows of names.

@ryanwwest
Copy link

I hope that other PR can solve this, or if not this can be merged. I frequently have the same problem when there are tons of Artists to display.

@thornbill
Copy link
Member

Closing in favor of #4830

@thornbill thornbill closed this Aug 15, 2024
@ryanwwest
Copy link

Does #4830 handle if there are 10 (or 2) very long artist names that still cause display overflow? I know that would in general solve the issue here, but couldn't there still be instances when 10 or 2 artists cause overflow?

@thornbill
Copy link
Member

No it would not solve for that, but I think it's an edge case of an edge case to have enough artists with ridiculously long names that it would be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants