Merge Snabb v2019.11 “Efraasia” release into Vita #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljsyscall: ensure size matches mask for get_mempolicy
As of GCC 8.1 a compiler error (stringop-truncation) will be raised as strncpy has potentially unsafe behavour, which is the case here. If strncpy's source (path in our case) is longer than the destination the destination will not be null terminated. Which is what sockaddr_un requires of sockaddr_un.sun_path. By reducing the copy size by one ensures as much as path as can be copied is and pads the rest of destination (the remaining one character) with null bytes, ensuring it's properly null terminated.
Memoize specialized functions
Fix errors due to bad strncpy behavour.
Move the ctype declaration of txdesc_t out of the init_tx_q() method to make its ctype identical in all instances of the driver. This eliminates certain side traces in the transmit code path.
The pointer type passed to append() and prepend() should always be canonicalized to "uint8_t *" to avoid side traces in code that uses these functions.
Add an optional callback which is invoked on an evicted entry to perform cleanup before the entry is purged from the table.
Make sure that packet.append() is called with a pointer of type uint8_t *. The detection of ICMP packets for PMTUD is simplified by only checking for next_header 58 on the fast path.
Respect the precondition for sort_array(). Use bit.band instead of modulo operator to check for multple of 8 of the fragment size.
The headers of all fragments are derived from the unfragmentable part of the original packet, hence the distinction for fragment #0 is not necessary.
Save next-hop MAC resolution in ARP and NDP apps respectively
This adds the test case of running two lwaftr instances each with two queues and performance testing them. To enable that test you must specify up to $PCI4 and four CPU's for the lwAFTR. Also improves the documentation at the top to help with how to call the script.
Add additional RSS test for 2 instances with 4 queues to release benchmarking script.
Update CHANGELOG.md with 2019.09.02 release
…-ctype-txdesc' into next
…pointer-cast-ptr' into next
Release Snabb lwAFTR v2019.06.01
Fix release benchmarks to always specify CPU
This updates the AVF driver to use the new PCI resource acquisition API from snabbco#1436 Fixes the currently broken :new() routine. The breakage happened when the avf branch was integrated with next, and I failed to test the merge. ^^'
Free PCI resources and remaining packets on rx/tx queues on shutdown. This fixes a resource leak.
This reverts commit 3ed5659.
- do not assert the revision date unless schema has revisions - do not try to load as source any compiled configs (with magic number header) that are rejected (instead bail with an error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/snabbco/snabb/releases/tag/v2019.11