intel_mp: fix ctype diversity for txdesc_t #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the ctype declaration of txdesc_t out of the init_tx_q() method to make its ctype identical in all instances of the driver. This eliminates certain side traces in the transmit code path.
|
Minor nitpick: maybe it should still be a |
|
I used the same style as for other such definitions, e.g. snabb/src/apps/intel_mp/intel_mp.lua Line 469 in 8f76782 I'm not sure if that was deliberate either (do we need to expose these to users of the module?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the ctype declaration of txdesc_t out of the init_tx_q() method
to make its ctype identical in all instances of the driver. This
eliminates certain side traces in the transmit code path.