-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge max-next into next #1449
Merged
Merged
Merge max-next into next #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… apps.test.npackets an app that only sends n packets from input to output
* lib/ljsyscall/syscall/linux/syscalls.lua: More robustly create multi-word bitmasks. * src/lib/numa.lua: Remove facility for blacklisting kernel versions. Re-enable bind_to_numa_node generally.
This commit makes four changes: (1) On the individual revision nodes in a schema, the revision date is now stored under `date` instead of `value`. (2) Schemas now have a `last_revision` property, indicating the date of the most recent revision. (3) This revision now gets serialized into compiled configurations. (4) When loading compiled configurations, we check that the compiled file's revision date corresponds to the what we are expecting. Fixes snabbco#1208.
The file in question is too small for the minimum ethernet frame size; with the CRC it becomes 58 bytes, which is smaller than the minimum frame size of 64, so it gets padded as it goes out on the wire, which later gets rejected on the receiver as its lengths don't make sense. In any case it doesn't test what it means to test, so remove it.
Remove bogus lwaftr benchmarking file
Detect version mismatch when loading compiled YANG configurations
Re-enable NUMA memory binding on newer kernels
Fix PCI affinity check for --preferred NUMA binding
This patch extends the NUMA module to be able to run some self-checks when it is used to reserve a CPU for a data plane, for example checking the CPU frequency scaling governor or the set of isolated CPUs.
Add more system performance diagnostics
This patch will print a warning if a network function tries to bind to a CPU, but irqbalance is detected. Irqbalance, installed by default on Debian-derived systems, will modify CPU affinities for IRQ handlers in an effort to spread out the IRQ-processing load among CPUs. However this is not what we want in Snabb; we do not want data-plane CPUs to run IRQ handlers, and we do not want bug reports coming from users that have this daemon installed. See https://github.com/snabbco/snabb/blob/master/src/doc/performance-tuning.md#avoid-interrupts-on-data-plane-cpus, for more details.
Detect irqbalance presence and suggest remedy
Improve snabb lwaftr run --help
Plug various resource leaks in context of (re)configuration
…itor-per-queue timers.ingress_drop_monitor: use app:get_rxstats() (was app:rxdrop())
Release Snabb lwAFTR v2019.06.01
Fix release benchmarks to always specify CPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1442 #1448 #1446 #1444
Cc @lukego