Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge max-next into next #1449

Merged
merged 137 commits into from
Nov 6, 2019
Merged

Merge max-next into next #1449

merged 137 commits into from
Nov 6, 2019

Conversation

eugeneia
Copy link
Member

@eugeneia eugeneia commented Nov 4, 2019

Includes #1442 #1448 #1446 #1444

Cc @lukego

petebristow and others added 30 commits January 29, 2019 20:13
… apps.test.npackets an app that only sends n packets from input to output
* lib/ljsyscall/syscall/linux/syscalls.lua: More robustly create
  multi-word bitmasks.

* src/lib/numa.lua: Remove facility for blacklisting kernel versions.
  Re-enable bind_to_numa_node generally.
This commit makes four changes:

  (1) On the individual revision nodes in a schema, the revision date is
      now stored under `date` instead of `value`.

  (2) Schemas now have a `last_revision` property, indicating the date
      of the most recent revision.

  (3) This revision now gets serialized into compiled configurations.

  (4) When loading compiled configurations, we check that the compiled
      file's revision date corresponds to the what we are expecting.

Fixes snabbco#1208.
The file in question is too small for the minimum ethernet frame size;
with the CRC it becomes 58 bytes, which is smaller than the minimum
frame size of 64, so it gets padded as it goes out on the wire, which
later gets rejected on the receiver as its lengths don't make sense.  In
any case it doesn't test what it means to test, so remove it.
Detect version mismatch when loading compiled YANG configurations
Re-enable NUMA memory binding on newer kernels
Fix PCI affinity check for --preferred NUMA binding
This patch extends the NUMA module to be able to run some self-checks
when it is used to reserve a CPU for a data plane, for example checking
the CPU frequency scaling governor or the set of isolated CPUs.
Add more system performance diagnostics
This patch will print a warning if a network function tries to bind
to a CPU, but irqbalance is detected.  Irqbalance, installed by default
on Debian-derived systems, will modify CPU affinities for IRQ
handlers in an effort to spread out the IRQ-processing load among
CPUs.  However this is not what we want in Snabb; we do not want
data-plane CPUs to run IRQ handlers, and we do not want bug reports
coming from users that have this daemon installed.

See https://github.com/snabbco/snabb/blob/master/src/doc/performance-tuning.md#avoid-interrupts-on-data-plane-cpus, for more details.
Detect irqbalance presence and suggest remedy
wingo and others added 25 commits October 25, 2019 13:44
Plug various resource leaks in context of (re)configuration
…itor-per-queue

timers.ingress_drop_monitor: use app:get_rxstats() (was app:rxdrop())
Fix release benchmarks to always specify CPU
@lukego lukego merged commit d7c8974 into snabbco:next Nov 6, 2019
lukego added a commit that referenced this pull request Nov 6, 2019
@lukego lukego added merged wip and removed wip labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants