virtual_ether_mux: Treat vlan=0 as vlan=nil #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit da4f98b makes apps.vlan validate the vlan ID argument. This correctly rejects the value zero as invalid (not allowed on the wire in 802.1Q standard.) However, the snabbnfv application does permit vlan=0 in its configuration file and this is used in various test vector files. This causes test failures. There are two obvious solutions. The first is to update all configurations to never use the invalid vlan=0. The second is to interpret vlan=0 as meaning "no VLAN." This commit implements the second one.
lukego
added a commit
to lukego/snabb
that referenced
this pull request
Aug 11, 2017
|
vlan=0 is valid and used to priority tag the traffic. If you google it, you'll find more info's about it: So a switch will still treat the traffic as untagged, but it processes the 802.1p bits. |
|
@mwiget Thanks for the tip. Maybe we should loosen the assertion in What do you think @alexandergall? |
lukego
added a commit
to lukego/snabb
that referenced
this pull request
Aug 15, 2017
VLAN-ID 0 is allowed as a "priority tag" i.e. for packets that are not on a VLAN but want the 802.1Q header to specify a priority. See snabbco#1206 (comment)
|
I reverted this change and updated the |
teknico
pushed a commit
to Igalia/snabb
that referenced
this pull request
Sep 12, 2017
VLAN-ID 0 is allowed as a "priority tag" i.e. for packets that are not on a VLAN but want the 802.1Q header to specify a priority. See snabbco#1206 (comment)
lukego
pushed a commit
that referenced
this pull request
Jan 2, 2019
Add additional RSS test for 2 instances with 4 queues to release benchmarking script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit da4f98b makes apps.vlan validate the vlan ID argument. This correctly rejects the value zero as invalid (not allowed on the wire in 802.1Q standard.) However, the snabbnfv application does permit vlan=0 in its configuration file and this is used in various test vector files. This causes test failures.
There are two obvious solutions. The first is to update all configurations to never use the invalid vlan=0. The second is to interpret vlan=0 as meaning "no VLAN." This commit implements the second one.
This change will be pulled directly onto #1203 as a fix to test failures.