add gee prototype module with example #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @shajoezhu fyi - this is a first prototype module. I would like to use this to show to the project folks next week, and then work with @cicdguy to deploy an initial version internally for project team playing around with it. your team can then help us to further improve and productionize it |
|
brilliant! thanks @danielinteractive , just looping @JiaLiu0001 into this thread as well, who will be developing the teal app for the crovab team. |
|
error with fixed |
Merged
merges into #664 The aim here is to: 1) Add `qenv` 2) Add reporter I also created the `template` for this module to be in line with other tmc modules.
mhallal1
reviewed
Nov 24, 2022
R/tm_a_gee.R
Outdated
| substitute( | ||
| expr = { | ||
| model_fit <- tern.gee::fit_gee( | ||
| vars = tern.gee:::vars_gee( |
There was a problem hiding this comment.
does vars_gee need to be exported from tern.gee?
close #694 <!--- Replace `#nnn` with your issue link for reference. --> Fixes #nnn Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com> Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
edelarua
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complements insightsengineering/tern.gee#2
Please don't update from main or merge. We want to base this on the current release.