-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
681 Add titles/footnotes for tm_a_gee
#691
Conversation
"Analysis Variable: ", col_source$aval_var, | ||
", Endpoint: ", filter_info$paramcd[[1]]$selected[[1]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use the variable label instead of the variable name in the title to be more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is necessary since the subtitles are mainly just to track input values when creating report cards. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Melkiades and @juliadedic1 I thought I would loop you in for your opinion on this as I am not entirely sure. I was wondering what you guys think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nolan-Steed what would be your proposed alternative in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliadedic1 I was thinking of grabbing the variable label instead of the variable name in the subtitle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a couple comments about the title
This reverts commit c91cfda.
Decided to leave as is to be consistent with the other modules. |
Closes #681