Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

681 Add titles/footnotes for tm_a_gee #691

Merged
merged 8 commits into from
Nov 30, 2022

Conversation

edelarua
Copy link
Contributor

Closes #681

@edelarua edelarua added the sme label Nov 24, 2022
@edelarua edelarua changed the base branch from main to 2_prototype November 24, 2022 23:20
@edelarua edelarua marked this pull request as ready for review November 24, 2022 23:22
@nsteed15 nsteed15 self-requested a review November 25, 2022 13:23
R/tm_a_gee.R Show resolved Hide resolved
Comment on lines +473 to +474
"Analysis Variable: ", col_source$aval_var,
", Endpoint: ", filter_info$paramcd[[1]]$selected[[1]],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the variable label instead of the variable name in the title to be more descriptive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is necessary since the subtitles are mainly just to track input values when creating report cards. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Melkiades and @juliadedic1 I thought I would loop you in for your opinion on this as I am not entirely sure. I was wondering what you guys think.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nolan-Steed what would be your proposed alternative in this case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliadedic1 I was thinking of grabbing the variable label instead of the variable name in the subtitle.

Copy link
Contributor

@nsteed15 nsteed15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a couple comments about the title

@nsteed15
Copy link
Contributor

Decided to leave as is to be consistent with the other modules.

@nsteed15 nsteed15 merged commit bda4285 into 2_prototype Nov 30, 2022
@nsteed15 nsteed15 deleted the 681_titles_footnotes@2_prototype branch November 30, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding titles and footnotes for tm_a_gee
3 participants