Import waf resources

[nunofernandes]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

At #424 a lot of AWF related resources got supported but only one or two support importing:

#4279 is one that is supported but a lot more aren't

New or Affected Resource(s)

• aws_wafregional_byte_match_set
• aws_wafregional_geo_match_set
• aws_wafregional_rate_based_rule
• aws_wafregional_regex_match_set
• aws_wafregional_regex_pattern_set
• aws_wafregional_rule
• aws_wafregional_rule_group
• aws_wafregional_size_constraint_set
• aws_wafregional_sql_injection_match_set
• aws_wafregional_web_acl
• aws_wafregional_web_acl_association
• aws_wafregional_xss_match_set

[bflad]

Resource import support for the following resources:

• aws_waf_rule_group
• aws_wafregional_byte_match_set
• aws_wafregional_rule
• aws_wafregional_rule_group
• aws_wafregional_web_acl

Has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[bflad]

If anyone is interested in helping out with this feature request by contributing to the project, we have recently added a Adding Resource Import Support section to the Contributing Guide which has information on how implement the necessary changes. 🎉

[bflad]

Hi folks 👋 As of version 2.33.0 of the Terraform AWS Provider, released a few weeks ago, these two resources now support import:

• aws_waf_byte_match_set
• aws_waf_rate_based_rule

For the rest of these below, import support was recently merged and will release with version 2.37.0 of the Terraform AWS Provider, by Thursday next week:

• aws_waf_geo_match_set
• aws_waf_regex_match_set
• aws_waf_regex_pattern_set
• aws_waf_size_constraint_set
• aws_waf_xss_match_set
• aws_wafregional_web_acl_association

Special thanks to @kterada0509 and @DrFaust92 for their help here. If you have additional requests for resource import support for other resources, please create a new feature request issue. Thanks!

[ghost]

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!