Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import aws_wafregional_ipset resource #9397

Closed
lpfeup opened this issue Jul 17, 2019 · 3 comments · Fixed by #9424
Closed

Import aws_wafregional_ipset resource #9397

lpfeup opened this issue Jul 17, 2019 · 3 comments · Fixed by #9424
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service.

Comments

@lpfeup
Copy link
Contributor

lpfeup commented Jul 17, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Importing aws_wafregional_ipset is not yet supported. Some other aws_wafregional resources already have import support #9212

New or Affected Resource(s)

  • aws_wafregional_ipset

Potential Terraform Configuration

resource "aws_wafregional_ipset" "ipset" {
  name = "tfIPSet"

  ip_set_descriptor {
    type  = "IPV4"
    value = "192.0.7.0/24"
  }

  ip_set_descriptor {
    type  = "IPV4"
    value = "10.16.16.0/16"
  }
}
@lpfeup lpfeup added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 17, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 17, 2019
@bflad bflad added service/waf Issues and PRs that pertain to the waf service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 18, 2019
@bflad
Copy link
Contributor

bflad commented Jul 18, 2019

If anyone is interested in helping out with this feature request by contributing to the project, we have recently added a Adding Resource Import Support section to the Contributing Guide which has information on how implement the necessary changes. 🎉

@lpfeup
Copy link
Contributor Author

lpfeup commented Jul 19, 2019

I'll create a PR for it

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants