Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support resource import for aws wafregional sql injection match set resource #9717

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9212

Release note for CHANGELOG:

resource/aws_wafregional_sql_injection_match_set: Support resource import

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafRegionalSqlInjectionMatchSet_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSWafRegionalSqlInjectionMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_changeNameForceNew
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_disappears
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_disappears
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_changeTuples
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_changeTuples
=== RUN   TestAccAWSWafRegionalSqlInjectionMatchSet_noTuples
=== PAUSE TestAccAWSWafRegionalSqlInjectionMatchSet_noTuples
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_basic
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_changeTuples
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_noTuples
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_disappears
=== CONT  TestAccAWSWafRegionalSqlInjectionMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_noTuples (54.17s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_disappears (54.18s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_basic (60.00s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_changeTuples (83.37s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_changeNameForceNew (95.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	95.173s

@teraken0509 teraken0509 requested a review from a team August 11, 2019 10:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 11, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 12, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kterada0509 🚀

--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_noTuples (10.24s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_disappears (10.49s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_basic (14.61s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_changeNameForceNew (19.76s)
--- PASS: TestAccAWSWafRegionalSqlInjectionMatchSet_changeTuples (31.28s)

@bflad bflad added this to the v2.24.0 milestone Aug 12, 2019
@bflad bflad merged commit a3263d0 into hashicorp:master Aug 12, 2019
bflad added a commit that referenced this pull request Aug 12, 2019
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

nywilken pushed a commit that referenced this pull request Sep 18, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
@teraken0509 teraken0509 deleted the feature/add-support-resource-import-for-aws_wafregional_sql_injection_match_set-resource branch March 5, 2020 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants